Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 90.57% 90.55% -0.02%
==========================================
Files 24 24
Lines 5239 5240 +1
==========================================
Hits 4745 4745
- Misses 494 495 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pnuu
left a comment
There was a problem hiding this comment.
This will need a unit test that checks the three options work:
- user doesn't define
deletein the config -> the default is used - user defines
delete = Trueand the file is deleted - user defines
delete = Falseand the file is not deleted
The current implementation will fail on the True case.
| LOGGER.exception("Could not decompress %s", pathname) | ||
| else: | ||
| if delete.lower() in ["1", "yes", "true", "on"]: | ||
| if delete in ["1", "yes", "true", "on"]: |
There was a problem hiding this comment.
This won't work if delete is set to any value that evaluates as boolean True.
|
@pnuu I traced all the options (1,yes..) back to True. If I use test_server.py on test folder I have no error message |
On server.py the delete option accepts only boolean
False, without quotes. An error occurred when you're working for the decompression of files on the fly.