Skip to content

Conversation

@GulSauce
Copy link
Member

📢 설명

해당 Pull Request에 대해 간략하게 설명해주세요!

✅ 체크 리스트

  • 리뷰어가 체크할 내용을 작성해주세요!

Copilot AI review requested due to automatic review settings November 14, 2025 08:28
@GulSauce GulSauce merged commit bd7e1f0 into develop Nov 14, 2025
3 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the application to version 1.3.2, improving timeout handling and updating deployment configuration.

  • Improves timeout handling in quiz collection to return partial results instead of failing completely
  • Updates GitHub Actions workflow to deploy from the main branch
  • Minor code formatting cleanup

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
app/main.py Removed extraneous blank line for cleaner formatting
app/adapter/request_generate_quiz_to_bedrock.py Changed timeout exception handling to log and return partial quiz results instead of raising an error
.github/workflows/prod_deploy.yml Updated deployment trigger from prod branch to main branch

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

except asyncio.TimeoutError:
raise TimeoutError
logger.info(
f"타임 아웃 발생: 전체 {quiz_count}개 메시지 중 {published_count - 1}개 수신"
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log message may be misleading. published_count - 1 represents the number of messages received, but not all received messages may be valid quizzes. Some messages may fail validation in try_make_generated_result() and not be added to the quizzes list. Consider logging both the number of messages received and the number of valid quizzes collected:

logger.info(
    f"타임 아웃 발생: 전체 {quiz_count}개 메시지 중 {published_count - 1}개 수신, {len(quizzes)}개 유효한 퀴즈 수집"
)
Suggested change
f"타임 아웃 발생: 전체 {quiz_count}개 메시지 중 {published_count - 1}개 수신"
f"타임 아웃 발생: 전체 {quiz_count}개 메시지 중 {published_count - 1}개 수신, {len(quizzes)}개 유효한 퀴즈 수집"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants