계승: v 1.3.3 (#57)

[GulSauce]

No description provided.

[Copilot]

Pull Request Overview

This PR introduces version 1.3.3 which adds chunk splitting functionality to ensure each chunk has exactly one quiz, along with minor code formatting improvements.

• Implements chunk splitting logic to divide chunks with quiz_count > 1 into multiple chunks with quiz_count = 1
• Adds deepcopy import to support independent chunk duplication
• Applies PEP 8 formatting improvements for parameter indentation and slice spacing

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.

File	Description
app/service/generate_service.py	Adds chunk splitting logic to divide multi-quiz chunks into single-quiz chunks before processing; imports deepcopy for chunk duplication
app/adapter/request_generate_quiz_to_bedrock.py	Minor formatting improvements: fixes parameter indentation and adds consistent spacing around slice operators

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The chunk splitting logic uses repeated list.insert() operations at the current index, which is inefficient. Each insertion is O(n) as it requires shifting all subsequent elements. For a chunk with quiz_count = k, this results in k-1 insertions, leading to O(k²) complexity for splitting a single chunk.

Consider building a new list instead:

split_chunks = []
for chunk in chunks:
    for _ in range(chunk.quiz_count):
        new_chunk = deepcopy(chunk)
        new_chunk.quiz_count = 1
        split_chunks.append(new_chunk)
chunks = split_chunks

This would be O(n) where n is the total number of resulting chunks.

Suggested change

	i = 0
	while i < len(chunks):
	chunk = chunks[i]
	while chunk.quiz_count > 1:
	# 기존 chunk 복제
	new_chunk = deepcopy(chunk)
	new_chunk.quiz_count = 1 # 복제된 chunk는 1회만 필요하다면 이렇게 설정
	# 현재 인덱스 i 앞에 삽입
	chunks.insert(i, new_chunk)
	# 원본 chunk의 count 감소
	chunk.quiz_count -= 1
	i += 1 # 삽입된 만큼 한 칸 이동
	i += 1
	for chunk in chunks:
	# Efficient chunk splitting: build a new list
	split_chunks = []
	for chunk in chunks:
	if chunk.quiz_count > 1:
	for _ in range(chunk.quiz_count):
	new_chunk = deepcopy(chunk)
	new_chunk.quiz_count = 1
	split_chunks.append(new_chunk)
	else:
	split_chunks.append(chunk)
	chunks = split_chunks
	for chunk in chunks:

[Copilot]

[nitpick] The comment "복제된 chunk는 1회만 필요하다면 이렇게 설정" (translated: "If the copied chunk only needs 1, set it like this") is misleading. The code unconditionally sets quiz_count = 1 for all copied chunks as part of the splitting algorithm, not conditionally based on some requirement. Consider clarifying the comment to reflect the actual behavior, such as: "각 복제된 chunk는 quiz_count를 1로 설정" (Each copied chunk has quiz_count set to 1).

Suggested change

	new_chunk.quiz_count = 1 # 복제된 chunk는 1회만 필요하다면 이렇게 설정
	new_chunk.quiz_count = 1 # 각 복제된 chunk는 quiz_count를 1로 설정

[Copilot]

[nitpick] Since ChunkInfo is a Pydantic v1 BaseModel (imported from pydantic.v1), consider using Pydantic's built-in copy() method instead of deepcopy():

new_chunk = chunk.copy(deep=True)

This is more idiomatic for Pydantic models and doesn't require importing deepcopy from the copy module.

[Copilot]

[nitpick] The comment "현재 인덱스 i 앞에 삽입" (Insert before current index i) is accurate, but the overall splitting logic could be clearer. The algorithm inserts new chunks before the current position and increments the index, which is counterintuitive. Consider adding a higher-level comment explaining the purpose:

# quiz_count > 1인 chunk를 quiz_count=1인 여러 chunk로 분할
# (Split chunks with quiz_count > 1 into multiple chunks with quiz_count = 1)