Open
Conversation
Changed code from cumbersome check code, to just checking for variant and switching to opposite. Also makes it easier to implement new holsters if others are added to EUP by simply putting variants in config file and not having to add to logic code.
Author
|
I'll go thru and remove the variables that aren't needed any longer. I'm checking my code now. |
Removed some unused variables.
Fixed canfire variable never getting called by removing it.
Had to put it back in (canFire)
Author
|
Fixed all linting errors. |
Added animation checks to (hopefully) prevent player getting stuck in holster/unholster animation loops.
removed function isPlayingAnim as it was unused and unnecessary.
removed other unused/unaccessed variables. Must appease the linting Gods. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed code from cumbersome check code, to just checking for variant and switching to opposite. Also makes it easier to implement new holsters if others are added to EUP by simply putting variants in config file and not having to add to logic code.
Describe Pull request
Code was changed to facilitate checking variant pairs from new config.lua. Then simply switching the componentID based on the current componentID. So in the config, as an example, I have:
[205] = 204 -- Full to empty
[204] = 205 -- Empty to full
This way you can simply edit the config and not have to change the cumbersome logic in weapdraw.lua.
If your PR is to fix an issue mention that issue here
Questions (please complete the following information):