add pipe ' |' (vbar) separated values option#949
Open
jobdiogenes wants to merge 1 commit intoqcif:developfrom
Open
add pipe ' |' (vbar) separated values option#949jobdiogenes wants to merge 1 commit intoqcif:developfrom
jobdiogenes wants to merge 1 commit intoqcif:developfrom
Conversation
Contributor
|
Hi, thanks for your contribution however I think more is required:
|
Author
|
Hi,
Stehphen, thanks prompt answer.
I change only the menu interface, which pass the character value to be used
load/save function.
I did all tests, (open and save) and work very well.
If you want can clone and build from my forke
https://github.com/jobdiogenes/data-curator.
Or download the Buid (linux)
https://github.com/jobdiogenes/data-curator/releases/tag/1.1.1
to make the tests.
Job DIogenes
Em dom, 25 de ago de 2019 às 02:21, Stephen Gates <notifications@github.com>
escreveu:
… Hi,
thanks for your contribution however I think more is required:
- There is no menu user interface
<https://github.com/ODIQueensland/data-curator/blob/develop/src/main/menu.js>
change to accommodate the import pipe file option
- You should also consider a similar export that will need you to
write an appropriate CSV dialect
<https://frictionlessdata.io/specs/csv-dialect/> entry with a pipe for
delimiter
- Automated tests should be provided
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#949>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJAVLIVC6A6S67BK6PU4JTQGIJG3ANCNFSM4IPHBO7A>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this pull request:
Reason:
@Stephen-Gates @mattRedBox