Conversation
Implement copyTo
Also simplified the `target.nodeId ? target.nodeId : target` ternary because, if target is a File, then it doesn't make sense stringifying it.
Fixes for copyTo implementation
Added --no-check because of this: info: The program failed type-checking, but it still might work correctly. hint: Re-run with --no-check to skip type-checking. It should not type check the tests! Why is it doing that? It works on my machine!
Attempt 1 to fix Deno tests
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v1.4.0
Changelog
Minor Changes
Attempt 1 to fix Deno tests (@qgustavor)
Added --no-check because of this: info: The program failed type-checking, but it still might work correctly. hint: Re-run with --no-check to skip type-checking.
Fixes for copyTo implementation (@qgustavor)
Implement copyTo (@qgustavor)
Allows copying files. Still needs fixing and testing before pushing.