update kafka to use codeclimate/poseidon gem #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 |
Contributor
Author
|
thanks @gordondiggs I actually just some got feedback that we’d like to use an extended version of the change I added (there’s another branch that builds off of it further, used at Square). So making that update to codeclimate/poseidon first |
ABaldwinHunter
force-pushed
the
abh-codeclimate-poseidon
branch
from
d871e77 to
8238f23
Compare
context - codeclimate-poseidon gem bump from 0.0.6 to 0.0.7 incorporates changes from a PR against bpot/poseidon that improves the way unavailable leaders are handled when a node goes down. bpot/poseidon@master...drcapulet:alexc-handle-errors changes in codeclimate-poseidon 0.0.7 incorporate the same changes qltysh-archive/poseidon@bf28e6e
ABaldwinHunter
force-pushed
the
abh-codeclimate-poseidon
branch
from
8238f23 to
a3f6be0
Compare
Contributor
Author
|
Updated to include additional messaging changes in a worthy PR that extended the first change: qltysh-archive/poseidon@fdfa4e2 I left An irb session in which I experimented with after bundling suggests that:
|
Contributor
|
👍 |
ABaldwinHunter
pushed a commit
that referenced
this pull request
Sep 25, 2015
update kafka to use codeclimate/poseidon gem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@codeclimate/review
Use our forked copy of poseidon to avoid issues with unavailable leaders when node is down
qltysh-archive/poseidon@07ae4df