chore(web): run oxlint before eslint #1
Conversation
🤖 Augment PR SummarySummary: This PR updates the web lint workflow to run Oxlint before ESLint. Changes:
Technical Notes: Oxlint runs using 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| catch (e) { | ||
| setLoading(false) | ||
| notify({ type: 'error', message: t('workflow.common.importFailure') }) | ||
| throw new Error('Import failed') |
There was a problem hiding this comment.
throw new Error('Import failed') changes the UX from a toast notification to an unhandled exception, and it will skip isCreatingRef.current = false below (potentially blocking subsequent imports). If this was done to satisfy a linter, consider ensuring the original error handling/cleanup behavior is preserved.
🤖 Was this useful? React with 👍 or 👎
| "lodash": "^4.17.21", | ||
| "magicast": "^0.3.5", | ||
| "nock": "^14.0.10", | ||
| "oxlint": "^1.31.0", |
There was a problem hiding this comment.
Adding oxlint@^1.31.0 introduces a Node requirement of ^20.19.0 || >=22.12.0 (as recorded in pnpm-lock.yaml), but engines.node currently allows >=v22.11.0 so installs on 22.11.x could fail. Consider aligning the engines range with oxlint’s minimum if 22.11 is meant to be supported.
🤖 Was this useful? React with 👍 or 👎
Benchmark PR from qodo-benchmark#66