Skip to content

Conversation

@hila-f-qodo
Copy link

Benchmark PR from qodo-benchmark#70

@augmentcode
Copy link

augmentcode bot commented Dec 31, 2025

🤖 Augment PR Summary

Summary: Switch the web TypeScript type-check step to use the faster native/Go-based TypeScript binary.

Changes:

  • Update CI (.github/workflows/style.yml) to run pnpm run type-check:tsgo.
  • Update the web pre-commit hook to use the new TS check command for staged TS changes.
  • Add type-check:tsgo script (tsg --noEmit) and add @typescript/native-preview dependency; lockfile updated accordingly.
  • Minor refactor in a unit test for tool parameter casting.

Technical Notes: This relies on @typescript/native-preview providing the tsg binary and may differ slightly from tsc behavior.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

echo "Type check failed. Please run 'pnpm run type-check' to fix the errors."
echo "Running TypeScript type-check:tsgo"
if pnpm run type-check:tsgo; then
echo "Type check failed. Please run 'pnpm run type-check:tsgo' to fix the errors."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if pnpm run type-check:tsgo; then check is inverted: it will exit 1 when the type-check succeeds and will continue when it fails. That also makes the "Type check failed" message fire on success, so the hook likely won’t block bad type errors.

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants