Conversation
akirakyle
force-pushed
the
deprecate-pauli
branch
from
aa13608 to
ca4478e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 93.00% 93.03% +0.02%
==========================================
Files 25 26 +1
Lines 3104 3257 +153
==========================================
+ Hits 2887 3030 +143
- Misses 217 227 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Krastanov
left a comment
Krastanov
left a comment
There was a problem hiding this comment.
Similar to the comments in the QuantumInterface PR, this is useful functionality that should not just be removed. I agree the name was poorly chosen, but we can deprecate the current name and just use a new name for the same capability (e.g. QubitBasis or something like that).
| b = SpinBasis(1//2) | ||
| # Test conversion of unitary matrices to superoperators. | ||
| q2 = PauliBasis(2) | ||
| q3 = PauliBasis(3) | ||
| q2 = b^2 | ||
| q3 = b^3 |
There was a problem hiding this comment.
PauliBasis is just being renamed, not completely removed, right? There is still value to having a convenient way to represent multi-qubit basis. This probably should just use the new name. Same for the other changes.
akirakyle
force-pushed
the
deprecate-pauli
branch
from
ca4478e to
81f7baa
Compare
2 participants
Should be merged in conjunction with qojulia/QuantumInterface.jl#52