Draft
Conversation
Krastanov
requested changes
Feb 2, 2026
Member
Krastanov
left a comment
There was a problem hiding this comment.
Thanks, this is a good start!
Check the comments I left in.
A few other things:
- this new functionality needs tests (check PBCCompiler.jl for an example of how to structure the tests)
- and it needs docs
- for ease of review, it would be helpful to post in the comments what a rendering looks like so we can discuss it before a full in-depth review.
Member
You should not include extensions manually. They are supposed to be loaded when the library is imported together with the weakdeps for the extension. Check out the details in the Pkg.jl manual. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new Makie-based Bloch sphere visualization extension for QuantumOpticsBase.
Features:
blochsphere(state::Ket)renders the Bloch sphere for any spin-1/2 quantum state.Ketinput.Testing:
using QuantumOpticsBase
using CairoMakie
include("ext/QuantumOpticsBaseMakieExt.jl")
using .QuantumOpticsBaseMakieExt
b = SpinBasis(1//2)
state = spinup(b)
f = blochsphere(state)