This repository was archived by the owner on Aug 27, 2025. It is now read-only.
Target iOS 17 and remove unused UIKit utils#17
Closed
Conversation
AlexNsbmr
changed the title
AlexNsbmr
changed the title
AlexNsbmr
requested review from
a team,
EmbusQade and
maiis
and removed request for
a team
maiis
approved these changes
Jul 29, 2025
EmbusQade
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to modernize the Swift package, remove unused or redundant code, and clean up associated tests. The most significant changes involve upgrading the Swift version and iOS platform, removing utility extensions and custom views, and deleting corresponding test cases.
Modernization Updates:
Package.swift: Updated the Swift tools version to5.10.1and the minimum iOS platform tov17to align with modern development standards.Codebase Cleanup:
ContainerCollectionViewCell.swift: A genericUICollectionViewCellsubclass.ContainerTableViewCell.swift: A genericUITableViewCellsubclass.UIStackView+Subviews.swift: Extensions for removing arranged subviews fromUIStackView.UIView+Pin.swift: Utility methods for pinning views to superviews or other views.UIButton+AllStates.swift: Methods for setting properties (e.g., title, color) for all button states.Test Case Removals:
UIButtonAllStatesTests.swift: Removed tests for setting button titles and colors for all states. [1] [2]UIStackViewSubviewsTests.swift: Removed tests for removing arranged subviews fromUIStackView.UIViewPinTests.swift: Removed tests for pinning views to superviews or other views.XCTestManifests.swiftto remove references to deleted test cases.Header Cleanup:
NotificationCenter+Utils.swiftView+ConditionalModifier.swiftUIApplication+Window.swiftThese changes simplify the codebase by removing outdated or unnecessary components while preparing it for modern Swift development.