[6599][IMP] hr_attendance_flex_rest_time: improve compute logic

[AungKoKoLin1997]

6599

[kanda999]

@AungKoKoLin1997
If I’m not mistaken, an Officer can update their own record as long as it is not the REST TIME field, right?

If that is the case, I think it would be better to allow them to update REST TIME as well, rather than linking it to another module.

[AungKoKoLin1997]

If I’m not mistaken, an Officer can update their own record as long as it is not the REST TIME field, right?

@kanda999 It only happens when we have hr_attendance_mange_own module is installed and add the new group for the officer.

If that is the case, I think it would be better to allow them to update REST TIME as well, rather than linking it to another module.

My current approach is not linking each other. There will no issue even hr_attendance_mange_own is not installed.

[AungKoKoLin1997]

@kanda999 I created a new glue module.

[AungKoKoLin1997]

I have no idea why test case is failed in this PR. There is no issue in my dev server.

[AungKoKoLin1997]

I have no idea why test case is failed in this PR. There is no issue in my dev server.

Fixed it. It is because of the attendance is not approved by default and odoo standard is approved by default.

[yostashiro]

As discussed, we probably don't need this module. We should update hr_attendance_flex_rest_time instead to allow officers (or anyone) to be able to edit their own rest times.

[AungKoKoLin1997]

I updated the hr_attendance_flex_rest_time instead of new glue module.

[yostashiro]

LGTM. 👍