Add PartialEq support on FilterType#80
Open
bboilot-ledger wants to merge 1 commit intoqsib-cbie:mainfrom
Open
Conversation
Contributor
|
We are in the middle of a large interface update to address performance issues and usability issues. Moving from free functions to traits with struct impls that allow (or prevent) monomorphization. The next release is planned after most of the current features are moved behind an interface that leads to better codegen and better control over allocations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋
While using sci-rs filter I came across an issue where
PartialEqtrait wasn't implemented forFilterTypewhile it's in implemented forFilterBandType.This PR implements this missing trait.
Apart from that, do you have an idea of when the next release is planned?
Thank you.