chore: add qubit spec. vs flux (precommit compliant) #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR focuses solely on pre-commit (pylint/black) compliance for newly added calibration files.
Reviewer note
GitHub shows all lines as changed because these files are newly added to the
KAVR_12182025branch.To avoid a full line-by-line review, the changes below are organized by file, summarizing all intentional, non-functional modifications.
File-by-file summary of changes (non-functional only)
03b_qubit_spectroscopy_vs_flux.py- Split lines exceeding max length (lines 181, 221)
-
custom_param(line 56)-
save_results(line 267)# pylint: disable=too-many-locals(line 69)- Required due to QUA program structure and is intentional
- Changed
any([q.z is None for q in qubits])toany(q.z is None for q in qubits)elseaftercontinue(line 252)- Simplified control flow
calibration_utils/qubit_spectroscopy_vs_flux/__init__.pycalibration_utils/qubit_spectroscopy_vs_flux/analysis.py- Split line exceeding max length (line 52)
# pylint: disable=invalid-nameform_pHvariable and attribute- Preserves physics notation convention (mutual inductance in pH)
__bool__()withbool()(line 143)calibration_utils/qubit_spectroscopy_vs_flux/parameters.py-
NodeSpecificParameters-
Parameters# pylint: disable=too-many-ancestorsforParameters- Follows internal rules: the class intentionally composes multiple mixins by design
calibration_utils/qubit_spectroscopy_vs_flux/plotting.pyNotes
quam_config) is expected and already explicitly disabled