Skip to content

Conversation

@Kyung-hoon-Jung0
Copy link
Collaborator

Summary

This PR focuses solely on pre-commit (pylint/black) compliance for newly added calibration files.

  • No functional or behavioral changes
  • Only docstrings, minor typo/formatting fixes, and explicit pylint rule handling
  • Goal: ensure clean pre-commit passes and reduce reviewer burden

Reviewer note

GitHub shows all lines as changed because these files are newly added to the KAVR_12182025 branch.
To avoid a full line-by-line review, the changes below are organized by file, summarizing all intentional, non-functional modifications.


File-by-file summary of changes (non-functional only)

04a_rabi_chevron.py
  • Added module docstring
  • Fixed long docstrings:
    • Split lines exceeding max length (lines 176, 214)
  • Added missing docstring for save_results (line 256)
  • Fixed import order:
    • Moved from dataclasses import asdict to the standard library import section
  • Added # pylint: disable=too-many-locals (line 72)
    • Required due to QUA program structure and is intentional
calibration_utils/rabi_chevron/__init__.py
  • Added module docstring
calibration_utils/rabi_chevron/analysis.py
  • Added/Modified module docstrings
  • Added missing docstring for process_raw_dataset (line 34)
calibration_utils/rabi_chevron/parameters.py
  • Added module docstring
  • Added class docstring for Parameters
  • Added # pylint: disable=too-many-ancestors for Parameters
    • Follows internal rules: the class intentionally composes multiple mixins by design
calibration_utils/rabi_chevron/plotting.py
  • Added module docstring

Notes

  • All files now pass the project's pylint checks via pre-commit
  • The remaining local-module import warning (quam_config) is expected and already explicitly disabled
  • No logic, algorithm, or runtime behavior was modified

Copy link
Collaborator

@paulQM paulQM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kyung-hoon-Jung0 Kyung-hoon-Jung0 merged commit 2d7e4f5 into KAVR_12182025 Jan 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants