ci: do not save the kas-container in the persistent space #1077
Conversation
quaresmajose
changed the title
quaresmajose
force-pushed
the
kas-container
branch
2 times, most recently
from
be12532 to
248141c
Compare
quaresmajose
changed the title
quaresmajose
force-pushed
the
kas-container
branch
2 times, most recently
from
2f93e7e to
a41eb53
Compare
quaresmajose
changed the title
quaresmajose
force-pushed
the
kas-container
branch
9 times, most recently
from
964fe84 to
4739748
Compare
quaresmajose
requested review from
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
Missing commit messages. Please always start commit message with the description of the problem that you are trying to solve
quaresmajose
force-pushed
the
kas-container
branch
from
4739748 to
a51466b
Compare
|
I rewrote commit messages and added the problem description |
only for the second patch. |
quaresmajose
force-pushed
the
kas-container
branch
from
ac70f7e to
a4f74e1
Compare
quaresmajose
force-pushed
the
kas-container
branch
3 times, most recently
from
414bd39 to
cd98190
Compare
Lets see if the auto-close will works, added: |
| - name: Update kas-container | ||
| - name: Setting up kas-container | ||
| run: | | ||
| KAS_CONTAINER=$RUNNER_TEMP/kas-container |
There was a problem hiding this comment.
can KAS_CONTAINER be defined in the env section at the top of the yml file? so that it is set only once.
There was a problem hiding this comment.
The answer is no, that would actually be ideal and that's where I started. But it is not possible because variable expansion is not supported, so the following gives an error:
env:
KAS_CONTAINER: ${{ runner.temp }}/kas-container
There was a problem hiding this comment.
Invalid workflow file: .github/workflows/build-yocto.yml#L1
(Line: 13, Col: 18): Unrecognized named-value: 'runner'. Located at position 1 within expression: runner.temp
There was a problem hiding this comment.
Pass the path or the temp path as an input?
There was a problem hiding this comment.
Using a variable is also good when we want to add some default command line args to the kas-container
| name: kas-lockfile | ||
| path: ci/ | ||
|
|
||
| - name: Download kas-container |
There was a problem hiding this comment.
is that needed here? we should download the artifact in build-yocto.yml instead, and leave that outside of the action file. it would be slightly nicer, no?
There was a problem hiding this comment.
If it is done in the action, it only needs to be done in a single location, which is what is currently implemented. If it is done in build-yocto.yml, it will have to be done every time a new worker is created. Then in build-yocto.yml it will have to be implemented in compile_warm_up and compile.
quaresmajose
force-pushed
the
kas-container
branch
from
b254c26 to
cd98190
Compare
|
This pull request has been marked as stale due to 30 days of inactivity. To prevent automatic closure in 5 days, remove the stale label or add a comment. You can reopen a closed pull request at any time. |
quaresmajose
force-pushed
the
kas-container
branch
from
cd98190 to
e304dae
Compare
quaresmajose
force-pushed
the
kas-container
branch
from
e304dae to
5a54768
Compare
Test run workflowTest jobs for commit 5a54768
|
|
Last set of tests failed due to infrastructure issue |
quaresmajose
force-pushed
the
kas-container
branch
from
5a54768 to
f5b3b71
Compare
Test run workflowTest jobs for commit f5b3b71
|
quaresmajose
force-pushed
the
kas-container
branch
from
f5b3b71 to
59b66f3
Compare
Test run workflowTest jobs for commit 59b66f3
|
Test Results 14 files ±0 26 suites - 2 49m 6s ⏱️ + 11m 55s For more details on these failures, see this check. Results for commit 1f8614f. ± Comparison against base commit 864453d. ♻️ This comment has been updated with latest results. |
Next patch will introduce new artifact downloads and uploads in the steps. It is better to start naming that steps of the job so that they are easier to identify when we look at the logs. Also rename the artifact to kas-lockfile since it is more obvious that it represents a kas locking file. Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
Since [1], kas-container is downloaded by a job and stored in the persistent storage (as KAS_CONTAINER). However this seems unsafe since each job will override kas-container in the persistent storage. We should download kas-container in a workflow specific folder instead. [1] qualcomm-linux#846 Fixes: qualcomm-linux#1015 Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
quaresmajose
force-pushed
the
kas-container
branch
from
59b66f3 to
1f8614f
Compare
Test run workflowTest jobs for commit 1f8614f
|
6 participants
Since [1], kas-container is downloaded by a job and stored in the persistent
storage (as KAS_CONTAINER). However this seems unsafe since each job will override
kas-container in the persistent storage. We should download kas-container in a
workflow specific folder instead.
[1] #846
Fixes: #1015