Hamoa IoT EVK support #1211
Hamoa IoT EVK support #1211
Conversation
shoudil
requested review from
lumag,
mwasilew,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
shoudil
force-pushed
the
hamoa-iot-evk-support
branch
from
66b8455 to
01aaa27
Compare
shoudil
force-pushed
the
hamoa-iot-evk-support
branch
from
01aaa27 to
4a7dd63
Compare
|
|
||
| do_deploy:append() { | ||
| install -d ${DEPLOYDIR}/${QCOM_BOOT_IMG_SUBDIR}/spinor | ||
| find "${S}/spinor" -maxdepth 1 -name '*.bin' -exec install -m 0644 {} ${DEPLOYDIR}/${QCOM_BOOT_IMG_SUBDIR}/spinor \; |
There was a problem hiding this comment.
I don't understand why you need to create the 'spinor' subfolder in DEPLOYDIR
There was a problem hiding this comment.
This is to align the directory structure in released boot binaries.
shoudil@shoudil2-gv:/local/mnt/workspace2/shoudil/Hamoa_Yocto_Mainine$ ls -l IQ-X.1.0-Ver.1.1-ubuntu-X1E80100-nhlos-bin*
-rw-r----- 1 shoudil users 17016 Nov 13 20:27 IQ-X.1.0-Ver.1.1-ubuntu-X1E80100-nhlos-bins.tar.gz
-rw-r----- 1 shoudil users 17016 Nov 13 20:27 IQ-X.1.0-Ver.1.1-ubuntu-X1E80100-nhlos-bins.tar.gz.1
IQ-X.1.0-Ver.1.1-ubuntu-X1E80100-nhlos-bins:
total 4
drwxr-xr-x 2 shoudil users 4096 Oct 14 15:27 spinor
shoudil@shoudil2-gv:/local/mnt/workspace2/shoudil/Hamoa_Yocto_Mainine$ tree -L 2 IQ-X.1.0-Ver.1.1-ubuntu-X1E80100-nhlos-bins
IQ-X.1.0-Ver.1.1-ubuntu-X1E80100-nhlos-bins
`-- spinor
|-- adsp_dtbs.elf
|-- adsp_lite.lzma
|-- aop_devcfg.mbn
|-- aop.mbn
|-- cpucp_dtbs.elf
There was a problem hiding this comment.
This is to align the directory structure in released boot binaries.
This doesn't really answer the 'why' question.
There was a problem hiding this comment.
Updated with "spinor" included in QCOM_BOOT_IMG_SUBDIR.
hamoa, IoT, EVK (also please fix PR subject) |
Test run workflowTest jobs for commit 4a7dd63
|
shoudil
force-pushed
the
hamoa-iot-evk-support
branch
from
4a7dd63 to
4432991
Compare
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
Also:
2025-11-19 07:07:41 - INFO - | find: ‘/work/build/tmp/work/all-qcom-linux/firmware-qcom-boot-x7181/1.1/sources/IQ-X7181_bootbinaries/spinor’: No such file or directory
|
|
||
| do_deploy:append() { | ||
| install -d ${DEPLOYDIR}/${QCOM_BOOT_IMG_SUBDIR}/spinor | ||
| find "${S}/spinor" -maxdepth 1 -name '*.bin' -exec install -m 0644 {} ${DEPLOYDIR}/${QCOM_BOOT_IMG_SUBDIR}/spinor \; |
There was a problem hiding this comment.
This is to align the directory structure in released boot binaries.
This doesn't really answer the 'why' question.
| # skip BLANK_GPT and WIPE_PARTITIONS for rawprogram xml files | ||
| for rawpg in `find ${DEPLOY_DIR_IMAGE}/${QCOM_PARTITION_FILES_SUBDIR} -maxdepth 1 -type f -name 'rawprogram*.xml' \ | ||
| ! -name 'rawprogram*_BLANK_GPT.xml' ! -name 'rawprogram*_WIPE_PARTITIONS.xml'`; do | ||
| install -m 0644 ${rawpg} . |
There was a problem hiding this comment.
Meanwhile, copy the programer outside
of spinor folder to be part of NVME flat build.
Why?
There was a problem hiding this comment.
NVME flat build include partition bins, hlos images efi.bin, rootfs.img and programmer to support build flash.
There was a problem hiding this comment.
That's not an answer for the question. Please add a comment that you are reusing SPI-NOR programmer for NVMe.
There was a problem hiding this comment.
Also, maybe it's too platform specific. Should it be done in bootbins?
There was a problem hiding this comment.
This is part of qcom flashable images deployment, should be implemented in create_qcomflash_pkg().
There was a problem hiding this comment.
Can't understand your response.
There was a problem hiding this comment.
Updated with below (in create_qcomflash_pkg):
if [ -e "${DEPLOY_DIR_IMAGE}/${QCOM_BOOT_FILES_SUBDIR}/xbl_s_devprg_ns.melf" ]; then
install -m 0644 "${DEPLOY_DIR_IMAGE}/${QCOM_BOOT_FILES_SUBDIR}/xbl_s_devprg_ns.melf" .
fi
There was a problem hiding this comment.
No, this is still machine-specific. Move that part to the IQ-X7181 boot binaries recipe.
|
Please use |
shoudil
force-pushed
the
hamoa-iot-evk-support
branch
2 times, most recently
from
04acbf1 to
384bc3b
Compare
Test run workflowTest jobs for commit 384bc3b
|
This issue got resolved in new push. |
Please resolve all review comments instead of fixing them one by one |
|
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
I will not approve "Proprietary" licence. Please change it to one of Qualcomm binary licenses (check with the corresponding team, which one should be used).
Yes, able to boot (as non-hlos release tag r1.0.r1_00004.0 used). |
shoudil
force-pushed
the
hamoa-iot-evk-support
branch
from
1ec1b07 to
39ac63b
Compare
Modified it as "LICENSE.qcom-2" in e4fa14b, BTW, is it also fine to use the licenses from meta-qcom itself instead of the one from package source ? recipes-graphics/adreno/qcom-adreno_1.838.3.bb:LICENSE = "LICENSE.qcom-2" recipes-test/diag-router/diag-router_1.0.2.bb:LICENSE = "LICENSE.qcom-2" recipes-bsp/hexagon-dsp-binaries/hexagon-dsp-binaries_20251125.bb: file://LICENSE.qcom-2;md5=165287851294f2fb8ac8cbc5e24b02b0 \ |
|
BTW, is it also fine to use the licenses from meta-qcom itself instead of the one from package source ? https://github.com/qualcomm-linux/meta-qcom/tree/master/licenses I checked several LICENSE.qcom-2 files from package source, looks file formats and hash values are not same, this can be avoided if we use same LICENSE files What would it mean? LIC_FILES_CHKSUM checksums the source files, so that the check fails if the license changes. |
Use the boot firmware from external release to generate spinor flat build for IQ-X7181 platform. Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com>
Deploy the boot firmware files which are used on iq-x7181-evk platform. Meanwhile ajdust the file match rule to deploy CDT file. Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com>
shoudil
force-pushed
the
hamoa-iot-evk-support
branch
from
39ac63b to
f07ca1a
Compare
It's compiling fine for packages, just a bit confused same license "LICENSE.qcom-2" have multiple file formats/names/hashvalues in different packages. |
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
Other than the order if two commits LGTM.
Add fucntion deploy_partition_files to take care of partition files deployment, and call it in flashable images generation. Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com>
Spinor firmware is needed on IQ-X7181 based devices, use the external released non-hlos images and deploy them to generate the flat build for spinor flash. Meanwhile, copy the programer outside of spinor folder to be part of NVMe flat build. Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com>
Define a package with hamoa-soc specific kernel modules Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com>
Upgrade qcom-ptool to consume partition conf files added for IQ-X7181 platform. Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com>
Enable kernel config to probe NVMe driver normally, which help to fix rootfs mount failure. Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com>
Add machine configuration file for IQ-X7181 platform, specify the paths of partition binaries for both NVMe and spinor, where partition bins will be consumed to create flat builds. Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com>
Pack DTB inside Unified Kernel Image to ensure proper device tree handling during boot. Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com>
This is the kas config file to support building iq-x7181-evk. Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com>
Update github workflow to build iq-x7181-evk in CI. Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com>
shoudil
force-pushed
the
hamoa-iot-evk-support
branch
from
f07ca1a to
b0fbcac
Compare
Test run workflowTest jobs for commit b0fbcac
|
|
I flashed the board and got it booting. It shows NVME drive: This is good enough for a health check. |
8 participants
To support Homoa IoT EVK board on meta-qcom, includes:
Depends on:
qualcomm-linux/qcom-ptool#51
qualcomm-linux/qcom-ptool#52
The generated flashable builds include builds for spinor and nvme:
tree -L 2 core-image-base-iq-x7181-evk.rootfs-20251116102537.qcomflash
core-image-base-iq-x7181-evk.rootfs-20251116102537.qcomflash
|-- dtb.bin
|-- dtb-hamoa-iot-evk-image.vfat
|-- efi.bin
|-- gpt_backup0.bin
|-- gpt_main0.bin
|-- patch0.xml
|-- rawprogram0.xml
|-- rootfs.img
|-- spinor
| |-- adsp_dtbs.elf
| |-- adsp_lite.lzma
| |-- aop_devcfg.mbn
| |-- aop.mbn
| |-- cpucp_dtbs.elf
| |-- cpucp.elf
| |-- devcfg_windows_hyp.mbn
| |-- gpt_backup0.bin
| |-- gpt_both0.bin
| |-- gpt_empty0.bin
| |-- gpt_main0.bin
| |-- hypvm.mbn
| |-- imagefv.elf
| |-- multi_image.mbn
| |-- patch0.xml
| |-- qupv3fw.elf
| |-- rawprogram0_BLANK_GPT.xml
| |-- rawprogram0_WIPE_PARTITIONS.xml
| |-- rawprogram0.xml
| |-- shrm.elf
| |-- tzapps.bin
| |-- tz.mbn
| |-- uefi.elf
| |-- wipe_rawprogram_PHY0.xml
| |-- wipe_rawprogram_PHY1.xml
| |-- wipe_rawprogram_PHY2.xml
| |-- wipe_rawprogram_PHY4.xml
| |-- wipe_rawprogram_PHY5.xml
| |-- wipe_rawprogram_PHY6.xml
| |-- wipe_rawprogram_PHY7.xml
| |-- xbl_config.elf
| |-- XblRamdump.xz
| |-- xbl_s_devprg_ns.melf
| |-- xbl_s.melf
| |-- zeros_1sector.bin
| |-- zeros_33sectors.bin
|
-- zeros_5sectors.bin |-- vmlinux |-- xbl_s_devprg_ns.melf |-- zeros_1sector.bin-- zeros_33sectors.bin