Properly compress Adreno firmware #1358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a part of do_install() we are compressing installed files. If other firmware is installed via appending to do_install(), it might get installed after compression happens, thus landing uncompressed. Move Adreno firmware installation to do_install:prepend() to make sure that it gets installed before compression step. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Adreno firmware is installed outside of FW_QCOM_PATH (it gets installed to FW_QCOM_BASE_PATH). Use that dir for finding firmware intead of the former one. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
lumag
requested review from
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
OE-Core uses first three digits of the GPU firmware gen to name the package. Rename SM8650 Adreno firmware packages accordingly. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Test run workflowTest jobs for commit af8d669
|
Test run workflowTest jobs for commit af8d669
|
ricardosalveti
approved these changes
Jan 7, 2026
Test run workflowTest jobs for commit d8de236
|
Test Results 19 files + 7 68 suites +56 55m 27s ⏱️ - 11m 55s Results for commit d8de236. ± Comparison against base commit ecf6c16. This pull request removes 2 and adds 24 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Test run workflowTest jobs for commit d8de236
|
Test run workflowTest jobs for commit d8de236
|
Test run workflowTest jobs for commit d8de236
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way it is handled, Adreno firmware ends up being uncompressed in the generated packages. Make sure that it gets compressed.