Fix AudioRecord parameter parsing #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rict with values Fixes qualcomm-linux#234 - Added --record-seconds as alias for --rec-secs parameter - Modified --strict to accept optional values (0 or 1) Signed-off-by: Teja Swaroop Moida <tmoida@qti.qualcomm.com>
tmoida
force-pushed
the
fix-audiorecord-params-clean
branch
from
9553f02 to
4d37ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #234 - AudioRecord test freezes on RB8
Root Cause
--rec-secsbut YAML was using--record-seconds--strictflag didn't accept values, but YAML was passing--strict 0Solution
Updated run.sh to:
--rec-secsand--record-secondsas aliases--strictto accept optional values 0 or 1