Skip to content

Fix: USBHost test results inconsistent #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
achauras-qcom wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

Fix: USBHost test results inconsistent #239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Runner/suites/Kernel/Baseport/USBHost/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,10 @@ echo "Enumerated USB devices..."
echo "$usb_output"

# Check if any USB devices were found
if [ "$device_count" -eq 0 ]; then
if [ -z "$usb_output" ] || [ "$device_count" -eq 0 ]; then
log_fail "$TESTNAME : Test Failed - No USB devices found."
echo "$TESTNAME FAIL" > "$res_file"
exit 1
Copy link
Contributor

@smuppand smuppand Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of causing a failure, let's change it to SKIP with exit code 0 if there is no USB devices found

Copy link
Contributor

@mwasilew mwasilew Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, isn't the goal of the test to exercise this feature?

Copy link
Contributor Author

@achauras-qcom achauras-qcom Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On changing the exit result to SKIP, in cases where a physically connected device does not enumerate, same test condition will be hit and it would report 'skip' instead of 'fail'. It is difficult to determine whether physically any USB devices were connected besides user input.
Is there a way we can take input parameter from user based on which we can skip certain tests?
Meanwhile I will also explore if we can determine physical connection without successful enumeration by checking port status, if that works reliably.

Copy link
Contributor

@mwasilew mwasilew Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO the current version is OK. The test should not be attempted on devices that are not prepared or won't support USB. For example on RB3g2 it won't pass with current meta-qcom build due to missing firmware. I believe this is an issue of test scheduling not the test itself and I vote to keep the version in this PR.


elif [ "$non_hub_count" -eq 0 ]; then
log_fail "$TESTNAME : Test Failed - Only USB hubs detected, no functional USB devices."
Expand Down
Loading