Skip to content

Conversation

@smuppand
Copy link
Contributor

@smuppand smuppand commented Jan 7, 2026

What

  • Added EGLINFO pipeline detection helpers to [lib_display.sh](http://lib_display.sh/).
  • Enhanced logging to clearly indicate whether the selected EGL/GL stack is using:
    • GPU pipeline (e.g., EGL driver: msm, GL_VENDOR: freedreno, etc.)
    • CPU pipeline (e.g., EGL driver: kms_swrast, GL_RENDERER: llvmpipe, etc.)
  • Updated kmscube and weston-wayland-test [run.sh](http://run.sh/) to call the helper before running the test, so CI logs capture the active rendering path.

Why

On some targets rendering can silently fall back to software (CPU) even though the test still runs. This change makes the pipeline explicit in logs, improving triage and reducing time to diagnose driver/stack issues.

Sample log - GPU

[INFO] 1970-01-01 06:03:38 - ---------------- EGLINFO pipeline detection (select one) ----------------
[INFO] 1970-01-01 06:03:38 - EGLINFO: Pipeline type: GPU (hardware)
[INFO] 1970-01-01 06:03:38 - EGLINFO: Pipeline=WAYLAND platform:
[INFO] 1970-01-01 06:03:38 - EGLINFO: EGL driver name: msm
[INFO] 1970-01-01 06:03:38 - EGLINFO: GL_VENDOR: freedreno
[INFO] 1970-01-01 06:03:38 - EGLINFO: GL_RENDERER: FD643
[INFO] 1970-01-01 06:03:38 - ---------------- End EGLINFO pipeline detection --------------------------

Sample log - CPU

[INFO] 2026-01-07 18:36:51 - ---------------- EGLINFO pipeline detection (select one) ----------------
[INFO] 2026-01-07 18:36:51 - EGLINFO: Pipeline type: CPU (software)
[INFO] 2026-01-07 18:36:51 - EGLINFO: Pipeline=GBM platform:
[INFO] 2026-01-07 18:36:51 - EGLINFO: EGL driver name: kms_swrast
[INFO] 2026-01-07 18:36:51 - EGLINFO: GL_VENDOR: Mesa
[INFO] 2026-01-07 18:36:51 - EGLINFO: GL_RENDERER: llvmpipe (LLVM 21.1.8, 128 bits)
[INFO] 2026-01-07 18:36:51 - ---------------- End EGLINFO pipeline detection --------------------------

@smuppand
Copy link
Contributor Author

smuppand commented Jan 7, 2026

@maheswaqcom Would you recommend failing the test if a CPU pipeline is detected instead of a GPU during detection?

@maheswaqcom
Copy link
Contributor

@maheswaqcom Would you recommend failing the test if a CPU pipeline is detected instead of a GPU during detection?

@smuppand first of all thanks for bringing this change.

IMO, we should skip tests under Graphics (weston-simple-egl & KMScube) instead of failing, for better alignment to call out GPU HW acceleration not enabled

@smuppand smuppand force-pushed the Display branch 2 times, most recently from a838f6e to 0b36dc8 Compare January 8, 2026 06:47
@smuppand
Copy link
Contributor Author

smuppand commented Jan 8, 2026

@maheswaqcom Would you recommend failing the test if a CPU pipeline is detected instead of a GPU during detection?

@smuppand first of all thanks for bringing this change.

IMO, we should skip tests under Graphics (weston-simple-egl & KMScube) instead of failing, for better alignment to call out GPU HW acceleration not enabled

Thank you for clarifying the requirement. I've submitted the new patch to address the SKIP.

Copy link
Contributor

@abbajaj806 abbajaj806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the comments.

Introduce EGLINFO pipeline detection helpers in lib_display.sh to select a
working platform (wayland/gbm/device/surfaceless) and print legacy-style
details (EGL driver, GL_VENDOR, GL_RENDERER).

Also emit an explicit hint indicating whether the selected path is GPU
(msm/freedreno/etc.) or CPU (kms_swrast/llvmpipe/etc.) for CI clarity.

Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Call display_print_eglinfo_pipeline in kmscube (auto/ gbm) runner to record which EGL stack is active (GPU vs CPU) before
executing the test workloads.

This improves triage on boards where rendering silently falls back to CPU.
Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Call display_print_eglinfo_pipeline in weston-wayland-test
(wayland) runner to record which EGL stack is active (GPU vs CPU) before
executing the test workloads.

This improves triage on boards where rendering silently falls back to CPU.

Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Copy link
Contributor

@abbajaj806 abbajaj806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abbajaj806 abbajaj806 merged commit ceff462 into qualcomm-linux:main Jan 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants