platforms: add machine specific partitions.conf for sm8750-mtp board #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumag
requested changes
Nov 3, 2025
gyenugul
force-pushed
the
pakala-kaanapali
branch
5 times, most recently
from
62ee01d to
217f066
Compare
gyenugul
requested review from
ndechesne,
sbanerjee-quic and
vkraleti
as code owners
Contributor
Author
|
@ricardosalveti @lumag Uploaded new patch |
lumag
requested changes
Nov 11, 2025
Contributor
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
- Please fix your git setup and correct the way your name is written. Then update the patch metadata and SoB.
- Make sure that commit message is a text. Sentences start with capital letters and end with a punctuation mark.
- Make sure to write all _b partitions, otherwise it's too easy to end with an unbootable board.
gyenugul
force-pushed
the
pakala-kaanapali
branch
from
217f066 to
abe1959
Compare
Contributor
Author
|
@lumag Addressed all the comments, please review the latest commit. |
Contributor
No, you didn't. I see _b partitions being ignored although we are writing data to a corresponding _a partition. |
Collaborator
|
@gyenugul confusion w.r.t _a/_b is arising because order is not maintained while listing. For example Please maintain consistency for ease of reviews. |
Contributor
|
@vkraleti I was mostly looking at the 'B' block of LUN 4. |
gyenugul
force-pushed
the
pakala-kaanapali
branch
from
abe1959 to
9fbed0e
Compare
Contributor
Author
Contributor
Please run 'make check' and fix the issues found (extend tests/integration/check-missing-files to cover the new files that are specific to this target.) |
Collaborator
|
@gyenugul |
gyenugul
force-pushed
the
pakala-kaanapali
branch
2 times, most recently
from
9dc7d42 to
3870489
Compare
Collaborator
|
Please split this commit into two and update check-missing-files in another commit. |
gyenugul
force-pushed
the
pakala-kaanapali
branch
from
3870489 to
7c06ecb
Compare
Contributor
Author
|
@vkraleti updated check-missing-files in another commit. |
Contributor
|
Please invert the order of the commits, you should first update check-missing-files and then add the partition definition for sm8750-mtp (every commit should be buildable). |
Adds: abl2esp-v7.elf, aop_devcfg.mbn, cpucp_dtbs.elf, dcd.mbn, devcfg_rfcomm.mbn, logfs_ufs_8mb.bin, pdp.elf, pdp_cdb.elf, sdi.mbn, xbl_s_devprg_ns.melf, xbl_s.melf. Files used by newer targets, such as sm8750-mtp. Signed-off-by: Gangabhavani Yenugula <gyenugul@qti.qualcomm.com>
Add initial partition scheme, contents.xml template for sm8750-mtp board. Signed-off-by: Gangabhavani Yenugula <gyenugul@qti.qualcomm.com>
gyenugul
force-pushed
the
pakala-kaanapali
branch
from
0387f87 to
a326480
Compare
Contributor
Author
|
@ricardosalveti Inverted the order of the commits. |
ricardosalveti
approved these changes
Nov 13, 2025
lumag
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add initial partition scheme, contents.xml template for sm8750-mtp board