Cleanup: remove unused/unsupported PM QoS code #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-lxu5
reviewed
Sep 5, 2025
src/fastrpc_apps_user.c
Outdated
| fastrpc_set_qos_latency(domain, h, FASTRPC_QOS_MAX_LATENCY_USEC); | ||
| break; | ||
| } | ||
| case RPC_PM_QOS: { |
Contributor
There was a problem hiding this comment.
why not remove this case?
Jianping-Li
force-pushed
the
issue-225-fix
branch
2 times, most recently
from
cae7ee6 to
776bcd8
Compare
ekanshibu
reviewed
Sep 5, 2025
|
|
||
| /** Control cpu low power modes based on RPC activity in 100 ms window. | ||
| * Recommended for latency sensitive use cases. | ||
| */ |
Contributor
There was a problem hiding this comment.
let's not remove the definitions of remote.h for now, might need to match it with SDK shipped version
Clean up unused PM QoS implementation. PM QoS is not supported by fastrpc driver, so related code is removed. Signed-off-by: Jianping Li <quic_jianpl@quicinc.com>
Jianping-Li
force-pushed
the
issue-225-fix
branch
from
776bcd8 to
770d865
Compare
ekanshibu
reviewed
Sep 6, 2025
| (nErr = manage_poll_qos(domain, h, RPC_DISABLE_QOS, lp->latency))); | ||
| /* Error ignored, currently meeting qos requirement is optional. Consider | ||
| * to error out in later targets */ | ||
| fastrpc_set_qos_latency(domain, h, FASTRPC_QOS_MAX_LATENCY_USEC); |
Contributor
There was a problem hiding this comment.
can you check if fastrpc_set_qos_latency call is still valid? Also need to evaluate adaptive QoS as well.
|
This pull request has been marked as stale due to 60 days of inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #225 by removing unused PM QoS code.
Changes include:
Fixes #225.