Add workflow to trigger a build of the package repo #251
Conversation
This workflow is an adapted copy of this workflow : https://github.com/qualcomm-linux/pkg-template/blob/main/.github/workflows/to_paste_in_upstream/pkg-build-pr-check.yml With this workflow in position, a PR in the upstream project repo (this one) triggers a build or the sister package repo. The special repo variable PKG_REPO_GITHUB_NAME will need to be set. See visit https://github.com/qualcomm-linux/pkg-template for more info about this whole CI workflow Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
| a full build of the package if it were to include these changes. | ||
|
|
||
| on: | ||
| pull_request_target: |
There was a problem hiding this comment.
should it be pull_request instead of pull_request_target? Or is it intended to run the workflow against the base repo instead of the PR's repo? I'm assuming this workflow is intended for all the PRs that are getting raised for this project.
There was a problem hiding this comment.
I have a habit of using 'pull_request_target' for security reason, so running the PR with the workflow from the basebranch, but using the content of the PR branch with the "upstream-repo-ref: ${{github.head_ref}}". What this does is that in the qcom-upstream-pr-pkg-build-reusable-workflow.yml reusable withflow, I checkout the content of the PR
| security-events: write | ||
|
|
||
| jobs: | ||
| package-build-pr-check: |
There was a problem hiding this comment.
adding timeout-minutes here might help to avoid stuck runners
There was a problem hiding this comment.
hmm, thats not a bad idea, but it seems like its not possible to add it here when using a reusable workflow, it would have to be in a job with the steps: statement, aka inside the reusable workflow
Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
2 participants
This workflow is an adapted copy of this workflow : https://github.com/qualcomm-linux/pkg-template/blob/main/.github/workflows/to_paste_in_upstream/pkg-build-pr-check.yml
With this workflow in position, a PR in the upstream project repo (this one) triggers a build or the sister package repo (in this case, it will be https://github.com/qualcomm-linux/pkg-fastrpc). The special repo variable PKG_REPO_GITHUB_NAME will need to be set to "qualcomm-linux/pkg-fastrpc" in this repo for this to work.
See visit https://github.com/qualcomm-linux/pkg-template for more info about this whole CI workflow.
When a PR is open in this repo, this workflow will in turn call this one :
https://github.com/qualcomm-linux/qcom-build-utils/blob/main/.github/workflows/qcom-upstream-pr-pkg-build-reusable-workflow.yml
What it will do is try to compile the debian package from the "qualcomm-linux/pkg-fastrpc" but with the changes from the PR opened on this side added in order to test that the debian package will still build if this PR were to be merged.
Ultimately, there will be even more tests downstream from that, like integration tests in a whole distro.