-
Notifications
You must be signed in to change notification settings - Fork 1
[FIRE-1020] feature: add compile_prompt function to the client as well as replace the package manager poetry with uv #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| [flake8] | ||
| max-line-length = 88 | ||
| max-line-length = 120 | ||
| exclude = | ||
| .git, | ||
| __pycache__, | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,25 +10,31 @@ jobs: | |||||||||
| python-version: ["3.8", "3.9", "3.10", "3.11"] | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - uses: actions/checkout@v4 | ||||||||||
| - uses: actions/checkout@v6 | ||||||||||
| with: | ||||||||||
| fetch-depth: 0 # Fetch all history for TruffleHog to scan commits | ||||||||||
| - name: Set up Python ${{ matrix.python-version }} | ||||||||||
| uses: actions/setup-python@v4.7.0 | ||||||||||
| uses: actions/setup-python@v6 | ||||||||||
| with: | ||||||||||
| python-version: ${{ matrix.python-version }} | ||||||||||
| - name: Install and configure Poetry | ||||||||||
| uses: snok/install-poetry@v1 | ||||||||||
|
|
||||||||||
| - name: Install uv | ||||||||||
| uses: astral-sh/setup-uv@v7 | ||||||||||
| with: | ||||||||||
| version: 1.6.1 | ||||||||||
| version: "0.9.22" | ||||||||||
|
|
||||||||||
| - name: Install dependencies | ||||||||||
| run: | | ||||||||||
| poetry install | ||||||||||
| pip install pytest | ||||||||||
| pip install openai | ||||||||||
| uv sync | ||||||||||
| uv pip install pytest openai | ||||||||||
|
|
||||||||||
| - name: Run style checks | ||||||||||
| run: | | ||||||||||
| make check-codestyle | ||||||||||
|
|
||||||||||
| - name: Creadentials search in source code - TruffleHog OSS | ||||||||||
| uses: trufflesecurity/trufflehog@v3.69.0 | ||||||||||
|
Comment on lines
35
to
36
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix typo in step name. "Creadentials" should be "Credentials". 📝 Proposed fix- - name: Creadentials search in source code - TruffleHog OSS
+ - name: Credentials search in source code - TruffleHog OSS📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||
|
|
||||||||||
| - name: Run tests | ||||||||||
| run: | | ||||||||||
| make test | ||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -189,7 +189,6 @@ target/ | |
| # pyenv | ||
| .python-version | ||
|
|
||
| # poetry | ||
| .venv | ||
|
|
||
| # pipenv | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2,8 +2,8 @@ | |||||||||
|
|
||||||||||
| ## Dependencies | ||||||||||
|
|
||||||||||
| We use `poetry` to manage the [dependencies](https://github.com/python-poetry/poetry). | ||||||||||
| If you dont have `poetry`, you should install with `make poetry-download`. | ||||||||||
| We use `uv` to manage the [dependencies](https://docs.astral.sh/uv/). | ||||||||||
| If you dont have `uv`, you should install with `make uv-download` or follow the [official installation guide](https://docs.astral.sh/uv/getting-started/installation/). | ||||||||||
|
Comment on lines
+5
to
+6
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor typo: "dont" → "don't". Proposed fix-If you dont have `uv`, you should install with `make uv-download` or follow the [official installation guide](https://docs.astral.sh/uv/getting-started/installation/).
+If you don't have `uv`, you should install with `make uv-download` or follow the [official installation guide](https://docs.astral.sh/uv/getting-started/installation/).📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||
|
|
||||||||||
| To install dependencies and prepare [`pre-commit`](https://pre-commit.com/) hooks you would need to run `install` command: | ||||||||||
|
|
||||||||||
|
|
@@ -12,7 +12,7 @@ make install | |||||||||
| make pre-commit-install | ||||||||||
| ``` | ||||||||||
|
|
||||||||||
| To activate your `virtualenv` run `poetry shell`. | ||||||||||
| To activate your virtual environment, uv will automatically handle it when running commands with `uv run`. | ||||||||||
|
|
||||||||||
| ## Codestyle | ||||||||||
|
|
||||||||||
|
|
||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: qualifire-dev/qualifire-python-sdk
Length of output: 3946
Fix configuration mismatch between flake8 and Black/isort.
The
.flake8change tomax-line-length = 120conflicts withpyproject.tomlwhich configures Black and isort toline-length = 88. Update either:pyproject.tomltoline-length = 120, or.flake8back tomax-line-length = 88Without this alignment, you'll have inconsistent line-length enforcement between formatting and linting.
🤖 Prompt for AI Agents