This repository was archived by the owner on Jul 13, 2024. It is now read-only.
VncPixelFormat now also allows copying of bpp16 rgb565 format #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 18, 2023 16:44
… an RGB32 Pixelformat and defined a static default VncPixelFormat which explicitely states what it does.
…ing the corresponding Bitmap Format. No bitmap conversion is taking place we just assure that the VncPixelFormat uses the same format for source and destination byte pointers. The user needs to assure that the bitmap is created with the correct format. Conversion of VncPixelFormat and System.Drawing.PixelFormat and vice versa has been added for the Example project.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the requirement to handle bpp16rgb565 format from an embedded device vnc server.
Therefore I added handling for bpp16 rgb565 format to the Windows Forms project by using the corresponding Bitmap Format.
No bitmap conversion is taking place we just assure that the VncPixelFormat uses the same format for source and destination byte pointers.
The user needs to assure that the bitmap is created with the correct format. Conversion of VncPixelFormat and System.Drawing.PixelFormat and vice versa has been added for the Example project.
I don't know if this is complete or if issues with code I did not use would occur. I tested if the example project still works with the original bpp32 format as well as the bpp16 rgp565 and it works fine. Have a look and let me know if this is alright.