Skip to content

ENH: Add wrappers for abseil containers #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ENH: Add wrappers for abseil containers #178

wants to merge 1 commit into from

Conversation

gerrymanoim
Copy link
Contributor

Closes #172.

Still WIP - need to add:

  • absl::btree_multimap
  • absl::btree_multiset
  • absl::flat_hash_map
  • absl::flat_hash_set
  • absl::node_hash_map
  • absl::node_hash_set

@github-actions github-actions bot added the enhancement New feature or request label Jul 2, 2020
@gerrymanoim
Copy link
Contributor Author

Having weird symbol not found issues trying to get any of the hash maps to run. Going to pause on this all for now.

llllllllll
llllllllll reviewed Jul 3, 2020
View reviewed changes
include/libpy/library_wrappers/abseil.h
#include "libpy/to_object.h"

namespace py {
namespace dispatch {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be shortened to namespace py::dispatch {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@llllllllll llllllllll llllllllll left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider adding optional headers for abseil
2 participants
@gerrymanoim @llllllllll