Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Python 3.12 image support
Summary
Adds Python 3.12 as a supported base image alongside the existing Python 3.10, parameterizing the Python version across all Dockerfiles and CI workflows.
Changes
Dockerfiles — All three Dockerfiles (Dockerfile, Dockerfile.base, Dockerfile.build) now accept a
PYTHON_VERSIONbuild arg (defaults to3.12) instead of hardcodingpython:3.10-slim.CI Workflows:
python-versionmatrix (3.10,3.12). PassesPYTHON_VERSIONbuild-arg and tags images asquara/blez-base:<python-version>.python-versionmatrix (3.10,3.12). PassesPYTHON_VERSIONbuild-arg and tags images asquara/blez-build:<python-version>.versionmatrix intopython-version×bluez-versionmatrix. Tags images asquara/blez:<python-version>_<bluez-version>. Passes bothPYTHON_VERSIONandBLUEZ_VERSIONbuild-args.3.12_5.66and3.12_5.85to the version matrix. Now parses bothPYTHON_VERSIONandBLUEZ_VERSIONfrom the composite matrix value and passes both to cp-build.sh.Scripts:
$PLATFORM $BLUEZ_VERSION...to$PLATFORM $PYTHON_VERSION $BLUEZ_VERSION.... Usesquara/blez-build:<python-version>instead of the non-existent:latesttag.Docs — Updated README.md with Docker build examples for both Python versions.
Breaking Changes
Image Matrix
quara/blez-base3.10,3.12quara/blez-build3.10,3.12quara/blez3.10_5.66,3.10_5.85,3.12_5.66,3.12_5.85