Skip to content

feat: Add target attribute to links in listing templates if provided #12293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
+7 −7
Draft

feat: Add target attribute to links in listing templates if provided #12293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5eff08
feat: Add target attribute to links in listing templates if provided
mcanouil Mar 14, 2025
dcfecd4
Merge branch 'main' into feat/listing-allow-target-href
mcanouil Apr 2, 2025
f722a3b
chore: Remove extra newline
mcanouil Apr 2, 2025
c94002c
chore: Remove extra newlines in EJS templates
mcanouil Apr 2, 2025
837ed6f
Merge branch 'main' into feat/listing-allow-target-href
mcanouil Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/resources/projects/website/listing/item-default.ejs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ return value;
let value = readField(item, field);
if (value !== undefined) {
print(`<div class="metadata-value listing-${field}">${listing.utilities.outputLink(item, field, value)}</div>`);
}
}
}
%>

Expand All @@ -41,7 +41,7 @@ print(`<div class="metadata-value listing-${field}">${listing.utilities.outputLi
<% if (fields.includes('image')) { %>

```{=html}
<div class="thumbnail"><a href="<%- item.path %>" class="no-external">
<div class="thumbnail"><a href="<%- item.path %>" <%= item.target ? `target="${item.target}"` : "" %> class="no-external">
<% if (item.image) { %>
<%= listing.utilities.img(itemNumber, item.image, "thumbnail-image", item['image-alt'], item['image-lazy-loading'] ?? listing['image-lazy-loading']) %>
<% } else { %>
Expand All @@ -55,9 +55,9 @@ print(`<div class="metadata-value listing-${field}">${listing.utilities.outputLi
::: {.body}

<% if (fields.includes('title')) { %>
<h3 class="no-anchor listing-title"><a href="<%- item.path %>" class="no-external"><%= item.title %></a></h3>
<h3 class="no-anchor listing-title"><a href="<%- item.path %>" <%= item.target ? `target="${item.target}"` : "" %> class="no-external"><%= item.title %></a></h3>
<% if (fields.includes('subtitle')) { %>
<div class="listing-subtitle"><a href="<%- item.path %>" class="no-external"><%= item.subtitle %></a></div>
<div class="listing-subtitle"><a href="<%- item.path %>" <%= item.target ? `target="${item.target}"` : "" %> class="no-external"><%= item.subtitle %></a></div>
<% } %>
<% } %>

Expand All @@ -76,7 +76,7 @@ print(`<div class="metadata-value listing-${field}">${listing.utilities.outputLi
<% if (fields.includes('description')) { %>

```{=html}
<div class="delink listing-description"><a href="<%- item.path %>" class="no-external">
<div class="delink listing-description"><a href="<%- item.path %>" <%= item.target ? `target="${item.target}"` : "" %> class="no-external">
```

<%= item.description %>
Expand All @@ -92,7 +92,7 @@ print(`<div class="metadata-value listing-${field}">${listing.utilities.outputLi
::: {.metadata}

```{=html}
<a href="<%- item.path %>" class="no-external">
<a href="<%- item.path %>" <%= item.target ? `target="${item.target}"` : "" %> class="no-external">
```

<% if (fields.includes('date') && item.date) { %>
Expand Down
2 changes: 1 addition & 1 deletion src/resources/projects/website/listing/item-grid.ejs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ return !["title", "image", "image-alt", "date", "author", "subtitle", "descripti
::: {.g-col-1 <%= listing.utilities.metadataAttrs(item) %> }

```{=html}
<a href="<%- item.path %>" class="quarto-grid-link">
<a href="<%- item.path %>" <%= item.target ? `target="${item.target}"` : "" %> class="quarto-grid-link">
<div class="quarto-grid-item card h-100 <%= `card-${align}` %><%= hideBorders ? ' borderless' : '' %>">
```

Expand Down
Loading