Skip to content

rpm: prefix PackageDB with kind#1640

Merged
github-actions[bot] merged 1 commit intoquay:mainfrom
RTann:rpm-pkgdb
Sep 17, 2025
Merged

rpm: prefix PackageDB with kind#1640
github-actions[bot] merged 1 commit intoquay:mainfrom
RTann:rpm-pkgdb

Conversation

@RTann
Copy link
Copy Markdown
Contributor

@RTann RTann commented Sep 16, 2025

Prior to #869, the PackageDB for RPMs were prefixed with the DB kind (sqlite, bdb, or ndb). With that change, the prefix was removed. I believe this was an accident. This PR adds it back

@RTann RTann requested review from crozzy and hdonnay September 16, 2025 22:40
@RTann RTann marked this pull request as ready for review September 16, 2025 23:00
@RTann RTann requested a review from a team as a code owner September 16, 2025 23:00
Copy link
Copy Markdown
Contributor

@crozzy crozzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RTann
Copy link
Copy Markdown
Contributor Author

RTann commented Sep 17, 2025

/fast-forward

@github-actions
Copy link
Copy Markdown

Triggered from #1640 (comment) by @​RTann.

Trying to fast forward main (4546119) to rpm-pkgdb (411374c).

Target branch (main):

commit 45461191cf638a6789d240a4755c12b4a0a161b2 (HEAD -> main, origin/main)
Author: Hank Donnay <hdonnay@redhat.com>
Date:   Wed Sep 17 15:21:40 2025 -0500

    rpm: fix use of `unique.Handle` pinning `fs.FS`
    
    This attempt to make the API impossible to misuse had some horrific,
    unintended side-effects for memory consumption, so remove it.
    
    Signed-off-by: Hank Donnay <hdonnay@redhat.com>

Pull request (rpm-pkgdb):

commit 411374c1989439c025ca267a80bd01c2703e2f3a (pull_request/rpm-pkgdb)
Author: Ross Tannenbaum <rtannenb@redhat.com>
Date:   Tue Sep 16 15:35:13 2025 -0700

    rpm: prefix PackageDB with kind
    
    Signed-off-by: RTann <rtannenb@redhat.com>
    
    rh-pre-commit.version: 2.3.2
    rh-pre-commit.check-secrets: ENABLED

Can't fast forward main (4546119) to rpm-pkgdb (411374c). main (4546119) is not a direct ancestor of rpm-pkgdb (411374c). Branches appear to have diverged at d5cc1b9:

* 45461191cf638a6789d240a4755c12b4a0a161b2 rpm: fix use of `unique.Handle` pinning `fs.FS`
| * 411374c1989439c025ca267a80bd01c2703e2f3a rpm: prefix PackageDB with kind
|/  
* d5cc1b94501f3433504223433733d3858d0faeb5 chore: v1.5.40 changelog bump

commit d5cc1b94501f3433504223433733d3858d0faeb5 (tag: v1.5.40)
Author: crozzy <1027041+crozzy@users.noreply.github.com>
Date:   Tue Sep 16 16:37:58 2025 +0000

    chore: v1.5.40 changelog bump
    
    Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Rebase locally, and then force push to rpm-pkgdb.

Signed-off-by: RTann <rtannenb@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@RTann
Copy link
Copy Markdown
Contributor Author

RTann commented Sep 17, 2025

/fast-forward

@github-actions github-actions bot merged commit 71a91e9 into quay:main Sep 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants