task: Do not remove Quay container on exit#178
Open
Conversation
When Quay container starts via the systemd unit, it gets automatically removed as a post-stop action. This causes problems when trying to diagnose startup issues, such as any validation errors. Logs are written in journal and can be pulled out by `journalctl` but sometimes it's just easier to call container logs instead. With this change, we set the removal of Quay container, if it exists, as an `ExecStartPre` action. This allows the container to persist after exiting for additional debugging.
harishsurf
added
the
ok-to-test
openshift-ci
Bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Quay container starts via the systemd unit, it gets automatically removed as a post-stop action. This causes problems when trying to diagnose startup issues, such as any validation errors. Logs are written in journal and can be pulled out by
journalctlbut sometimes it's just easier to call container logs instead. With this change, we set the removal of Quay container, if it exists, as anExecStartPreaction. This allows the container to persist after exiting for additional debugging.