Skip to content

ci: pass image refs from build job to fix online install pre-pull#260

Merged
harishsurf merged 1 commit intoquay:mainfrom
harishsurf:fix-ci-online-prepull
Apr 15, 2026
Merged

ci: pass image refs from build job to fix online install pre-pull#260
harishsurf merged 1 commit intoquay:mainfrom
harishsurf:fix-ci-online-prepull

Conversation

@harishsurf
Copy link
Copy Markdown
Contributor

With pull_request_target, test jobs checkout the base branch, so the pre-pull step reads .env from main instead of the PR branch. When a PR bumps image tags in .env, the pre-pull fetches the old version while the binary expects the new one, causing an auth failure on pull.

Pass image refs as job outputs from the build job (which checks out the PR branch) so the test jobs always pre-pull the correct versions.

With pull_request_target, test jobs checkout the base branch, so the
pre-pull step reads .env from main instead of the PR branch. When a PR
bumps image tags in .env, the pre-pull fetches the old version while the
binary expects the new one, causing an auth failure on pull.

Pass image refs as job outputs from the build job (which checks out the
PR branch) so the test jobs always pre-pull the correct versions.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@harishsurf harishsurf added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 14, 2026
@harishsurf harishsurf merged commit bfb29b1 into quay:main Apr 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Development

Successfully merging this pull request may close these issues.

2 participants