-
Notifications
You must be signed in to change notification settings - Fork 151
Contract one time oracle query #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
philippwerner
wants to merge
17
commits into
feature/2025-12-09-oracle-machine
Choose a base branch
from
feature/2025-12-15-contract-one-time-oracle-query
base: feature/2025-12-09-oracle-machine
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Contract one time oracle query #708
philippwerner
wants to merge
17
commits into
feature/2025-12-09-oracle-machine
from
feature/2025-12-15-contract-one-time-oracle-query
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using plain function pointers for referencing user procedures for notifications may cause failures when snapshots are saved and loaded, because function pointer may change when the node is restarted with a snapshot in the middle of an epoch. As a solution, notification contract procedures must be registered at node startup. The function pointer and related data is stored in a registry and referenced by a procedure ID that is defined by the contract index and the line of the procedure in the source code (which stay constant between restarts and thus can be stored in the oracle engine state snapshot file).
…-15-contract-one-time-oracle-query
017c75f to
45e7b62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #672