JWWEB-687 Add tests for merge assets function #1119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IViol
changed the title
stcherenkov
reviewed
Nov 22, 2019
Contributor
stcherenkov
left a comment
stcherenkov
left a comment
There was a problem hiding this comment.
Good job! But it needs some improvements.
| @@ -0,0 +1,26 @@ | |||
| // @flow strict | |||
|
|
|||
| import addETHAsset from '../addETHAsset' | |||
Contributor
There was a problem hiding this comment.
Better to import from index.js because it is the public interface you are testing for existence.
| expect(eth.blockchainParams).toBeDefined() | ||
| expect(eth.blockchainParams.address).toEqual(ETH_ADDRESS) | ||
| }) | ||
| }) |
Contributor
There was a problem hiding this comment.
Also tests required:
- non-empty assets list
- with
ethereumalready in assets list - with mock for
getAssetsMainnetfunction returning various results (empty, non-empty, withethereum)
| const jnt: ?DigitalAsset = result[JNT_ADDRESS] | ||
|
|
||
| if (!jnt) { | ||
| throw new Error('JNT asset not found') |
Contributor
There was a problem hiding this comment.
No need to throw here.
First, you are testing jnt existence in next assertion.
Second, if test continues execution on assertion not passed, you could use safe assertions after, for example: https://jestjs.io/docs/en/expect#tohavepropertykeypath-value
Contributor
Author
There was a problem hiding this comment.
const eth: ?DigitalAsset = result[ETH_ADDRESS] means that eth can be null or undefined.
expect(eth).toBeDefined() will not throw if eth is null.
| const azbit: ?DigitalAsset = result[AZBIT_ADDRESS_CS] | ||
|
|
||
| if (!azbit) { | ||
| throw new Error('Azbit asset not found') |
| const azbit: ?DigitalAsset = result[AZBIT_ADDRESS_CS] | ||
|
|
||
| if (!azbit) { | ||
| throw new Error('Azbit asset not found') |
| const jnt: ?DigitalAsset = result[JNT_ADDRESS] | ||
|
|
||
| if (!jnt) { | ||
| throw new Error('JNT asset not found') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.