Support bulk enqueue with differing class and options #420
+289
−160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtcristo
force-pushed
the
dtcristo/bulk-enqueue-improvements
branch
from
771aba0 to
6a803fa
Compare
Contributor
Author
|
I rebased this PR on top of #421 as CI was broken due to Bundler version. |
ZimbiX
requested changes
Mar 5, 2024
Member
ZimbiX
left a comment
ZimbiX
left a comment
There was a problem hiding this comment.
Great work! Thanks for this :D
[Bundler 2.5 dropped support for Ruby 2.7](https://github.com/rubygems/rubygems/releases/tag/bundler-v2.5.0). Since we are testing with Ruby 2.7, we should pin the version of Bundler to 2.4.x since this is the last version that's compatible with 2.7.
Prepare spec for bulk enqueue refactor to support bulk enqueue of jobs with differing job class and job options.
dtcristo
force-pushed
the
dtcristo/bulk-enqueue-improvements
branch
from
6a803fa to
63f5817
Compare
Allow bulk enqueue of multiple different job classes and differing job options in a single `.bulk_enqueue` block. Each job can now differ by job class, queue, priority, run at and tags (in addition to args and kwargs).
dtcristo
force-pushed
the
dtcristo/bulk-enqueue-improvements
branch
from
63f5817 to
4835936
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #340.
Allow bulk enqueue of multiple different job classes and differing job options in a single
.bulk_enqueueblock. Each job can now differ by job class, queue, priority, run at and tags (in addition to args and kwargs).