Skip to content

Add UKACM & GACM tutorial: Quantifying Uncertainty due to heterogeneous material fields#293

Open
reginabuehler wants to merge 1 commit intoqueens-py:mainfrom
reginabuehler:queens-4C-tutorials-pt-2
Open

Add UKACM & GACM tutorial: Quantifying Uncertainty due to heterogeneous material fields#293
reginabuehler wants to merge 1 commit intoqueens-py:mainfrom
reginabuehler:queens-4C-tutorials-pt-2

Conversation

@reginabuehler
Copy link
Copy Markdown
Contributor

@reginabuehler reginabuehler commented Mar 2, 2026

Description and Context:
What and Why?

This PR includes the final tutorial from the UKACM & GACM Autumn School workshop into QUEENS.
Huge thanks and full credit to @gilrrei, who developed and authored the original tutorial.

The fourth tutorial is added into the QUEENS documentation as 4_quantifying_uncertainty_due_to_heterogeneous_material_fields and tests this by including it into the documentation build of the CI pipeline.

The content of the tutorial was peer-reviewed during the development for the workshop, but I would appreciate someone taking a look at the content again.
I'd also appreciate someone checking the doc strings and type hints of the random_field.py module since I am not familiar with that module.

To reduce code redundancy the utility function used both in the 3rd and 4th tutorial was refactored and tutorials turned into a package. The import is ensured by small changes in the Github workflow as well as the actual Jupyter notebook. One option to eliminate those small changes might be to refactor the tutorials/utils.py into src/queens/utils/ if desired.

Notes during development

  • Improve docstrings and type hints
  • Fix docstring in 3rd tutorial and eliminate code redundancy
  • Check local run
  • Adapt text for documentation/online tutorial
  • Fix import of tutorials.utils

Refactoring of utility and plotting functions:

  • It is necessary to make sure the package tutorials can be imported locally and also in the CI. Can this be done in the GitHub actions workflow or do I need to add to sys path for docs? Apparently, in GitHub actions workflow is sufficient. Maybe put utility function in src/queens/utils?

Related Issues and Pull Requests

Interested Parties

Note: More information on the merge request procedure in QUEENS can be found in the Submit a pull request section in the CONTRIBUTING.md file.

@reginabuehler reginabuehler self-assigned this Mar 4, 2026
@reginabuehler reginabuehler marked this pull request as ready for review March 4, 2026 14:11
Copy link
Copy Markdown
Member

@gilrrei gilrrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work. The docstrings and typehinting of the random field class lgtm.

@reginabuehler reginabuehler force-pushed the queens-4C-tutorials-pt-2 branch from 3b0d6a8 to 93db88a Compare March 25, 2026 17:23
@reginabuehler reginabuehler requested a review from gilrrei March 25, 2026 17:55
gilrrei
gilrrei previously approved these changes Mar 27, 2026
Copy link
Copy Markdown
Member

@leahaeusel leahaeusel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge this yet, I have a few stylistic additions but haven't finished reviewing yet 🙈

Copy link
Copy Markdown
Member

@leahaeusel leahaeusel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this really nice tutorial @gilrrei and for getting it ready for the main branch @reginabuehler! 🙏

I only have a few comments to improve grammar and consistency with the other tutorials.

…us Material Fields in 4C

Co-authored-by: Gil Robalo Rei <72092883+gilrrei@users.noreply.github.com>
@reginabuehler reginabuehler force-pushed the queens-4C-tutorials-pt-2 branch from d191911 to 63a1641 Compare March 30, 2026 14:46
@reginabuehler
Copy link
Copy Markdown
Contributor Author

Thanks for the detailed review, @leahaeusel! I have applied your suggestions.

The commits are now squashed and co-authored by @gilrrei. Thanks for developing and providing the tutorial! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants