Add UKACM & GACM tutorial: Quantifying Uncertainty due to heterogeneous material fields#293
Open
reginabuehler wants to merge 1 commit intoqueens-py:mainfrom
Open
Add UKACM & GACM tutorial: Quantifying Uncertainty due to heterogeneous material fields#293reginabuehler wants to merge 1 commit intoqueens-py:mainfrom
reginabuehler wants to merge 1 commit intoqueens-py:mainfrom
Conversation
gilrrei
reviewed
Mar 6, 2026
Member
gilrrei
left a comment
There was a problem hiding this comment.
Thanks for the work. The docstrings and typehinting of the random field class lgtm.
...geneous_material_fields/4_quantifying_uncertainty_due_to_heterogeneous_material_fields.ipynb
Outdated
Show resolved
Hide resolved
3b0d6a8 to
93db88a
Compare
gilrrei
previously approved these changes
Mar 27, 2026
leahaeusel
requested changes
Mar 30, 2026
Member
leahaeusel
left a comment
There was a problem hiding this comment.
Please don't merge this yet, I have a few stylistic additions but haven't finished reviewing yet 🙈
leahaeusel
reviewed
Mar 30, 2026
Member
leahaeusel
left a comment
There was a problem hiding this comment.
Thanks a lot for this really nice tutorial @gilrrei and for getting it ready for the main branch @reginabuehler! 🙏
I only have a few comments to improve grammar and consistency with the other tutorials.
...geneous_material_fields/4_quantifying_uncertainty_due_to_heterogeneous_material_fields.ipynb
Outdated
Show resolved
Hide resolved
...geneous_material_fields/4_quantifying_uncertainty_due_to_heterogeneous_material_fields.ipynb
Outdated
Show resolved
Hide resolved
...geneous_material_fields/4_quantifying_uncertainty_due_to_heterogeneous_material_fields.ipynb
Outdated
Show resolved
Hide resolved
...geneous_material_fields/4_quantifying_uncertainty_due_to_heterogeneous_material_fields.ipynb
Outdated
Show resolved
Hide resolved
...geneous_material_fields/4_quantifying_uncertainty_due_to_heterogeneous_material_fields.ipynb
Outdated
Show resolved
Hide resolved
...geneous_material_fields/4_quantifying_uncertainty_due_to_heterogeneous_material_fields.ipynb
Outdated
Show resolved
Hide resolved
...geneous_material_fields/4_quantifying_uncertainty_due_to_heterogeneous_material_fields.ipynb
Outdated
Show resolved
Hide resolved
...geneous_material_fields/4_quantifying_uncertainty_due_to_heterogeneous_material_fields.ipynb
Outdated
Show resolved
Hide resolved
...geneous_material_fields/4_quantifying_uncertainty_due_to_heterogeneous_material_fields.ipynb
Outdated
Show resolved
Hide resolved
...geneous_material_fields/4_quantifying_uncertainty_due_to_heterogeneous_material_fields.ipynb
Outdated
Show resolved
Hide resolved
6b92a29 to
d191911
Compare
…us Material Fields in 4C Co-authored-by: Gil Robalo Rei <72092883+gilrrei@users.noreply.github.com>
d191911 to
63a1641
Compare
Contributor
Author
|
Thanks for the detailed review, @leahaeusel! I have applied your suggestions. The commits are now squashed and co-authored by @gilrrei. Thanks for developing and providing the tutorial! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Context:
What and Why?
This PR includes the final tutorial from the UKACM & GACM Autumn School workshop into QUEENS.
Huge thanks and full credit to @gilrrei, who developed and authored the original tutorial.
The fourth tutorial is added into the QUEENS documentation as
4_quantifying_uncertainty_due_to_heterogeneous_material_fieldsand tests this by including it into the documentation build of the CI pipeline.The content of the tutorial was peer-reviewed during the development for the workshop, but I would appreciate someone taking a look at the content again.
I'd also appreciate someone checking the doc strings and type hints of the
random_field.pymodule since I am not familiar with that module.To reduce code redundancy the utility function used both in the 3rd and 4th tutorial was refactored and
tutorialsturned into a package. The import is ensured by small changes in the Github workflow as well as the actual Jupyter notebook. One option to eliminate those small changes might be to refactor thetutorials/utils.pyintosrc/queens/utils/if desired.Notes during development
tutorials.utilsRefactoring of utility and plotting functions:
tutorialscan be imported locally and also in the CI. Can this be done in the GitHub actions workflow or do I need to add to sys path for docs? Apparently, in GitHub actions workflow is sufficient. Maybe put utility function insrc/queens/utils?Related Issues and Pull Requests
Interested Parties