Conversation
|
Btw the reason for resorting to an absolute path instead of an environment variable to get the build-stage files was because neither |
|
In order to skip having to use absolute paths I just also discovered you could copy in the build-step to the stage-step (/remove the stage-step override completely): This might be a cleaner solution |
|
Build and boot are succesful. Seems to function normally. |
|
LGTM, looks like we might need to upgrade the wrapper again though to be in line with #700? |
|
Yep that sounds logical. Just tested it and it seemed to build succesfully on WSL2 Ubuntu machine. |
|
(Builds/results of previous commits were tested on a real Ubuntu PC, I just didn't feel like rebooting my computer just now :P ) |
|
Thanks, should a push/new commit to master automatically trigger a build for the edge channel? |
|
Yes :-) |
|
Hmm it doesn't seem to have done that. Maybe it's got 'blocked' since the last pushes were causing errors? |
|
It looks like it ran, but:
[image: image.png]
...not immediately sure why, there's nothing obvious in the logs.
…On Sat, 10 Jan 2026 at 10:19, Ebbe Zeinstra ***@***.***> wrote:
*ebbez* left a comment (quelea-projection/Quelea#698)
<#698 (comment)>
Hmm it doesn't seem to have done that. Maybe it's got 'blocked' since the
last pushes were causing errors?
—
Reply to this email directly, view it on GitHub
<#698 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZ6JDMANUUINWYCBBJPCJL4GDG3JAVCNFSM6AAAAACQB4PJB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMZSGMZTMNRUGM>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
--
Thanks,
Michael
|
|
Ok, I've run a build manually and looks like that's worked, so was probably
a temporary Snapcraft glitch.
…On Sat, 10 Jan 2026 at 10:46, Michael Berry ***@***.***> wrote:
It looks like it ran, but:
[image: image.png]
...not immediately sure why, there's nothing obvious in the logs.
On Sat, 10 Jan 2026 at 10:19, Ebbe Zeinstra ***@***.***>
wrote:
> *ebbez* left a comment (quelea-projection/Quelea#698)
> <#698 (comment)>
>
> Hmm it doesn't seem to have done that. Maybe it's got 'blocked' since the
> last pushes were causing errors?
>
> —
> Reply to this email directly, view it on GitHub
> <#698 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABZ6JDMANUUINWYCBBJPCJL4GDG3JAVCNFSM6AAAAACQB4PJB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMZSGMZTMNRUGM>
> .
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***>
>
--
Thanks,
Michael
--
Thanks,
Michael
|
|
Ok cool, thanks! :-) |
* Fix Snap build * Fix Snap .desktop file * Remove stage-step to avoid absolute paths * Update Gradle version to 9.2.1
This reverts commit 96922e8.
There were some problems with the Snap build causing it to fail:
downloadJres,downloadGStreamer,createQueleaExe64), but those tasks could not be removed because thecopyToDisttask would fail since it (copyToDist) expects the Windows components to be present./build/quelea/parts/quelea/build/dist/didn't seem to exist when testing to pack the Snap withsnapcraft pack..desktop-file contained aVersion=2019entry, but when I was building Flatpaks earlier this year, I noticed there was a warning stating that theVersionentry was incorrectly used. It appears it can only be used to specify the.desktop-file specification version, not the application's version.Fixed by:
gradle-9.1.0/bincopyToDistto only unzip a Windows JRE when present./root/parts/quelea/build/dist/. I'm unsure at this time if this is the correct path when it builds on Ubuntu/Canonical/Snapcraft servers/runners, but it worked when locally executingsnapcraft packwhich I believe simulates a normal build environment because it makes a VM in which the Snap gets packed/built.Version=entry from the .desktop file.jar/directory withapp/to be more clear what is contained inside the directory.