Quentin testing by quentinDERORY · Pull Request #19 · quentinDERORY/magma

quentinDERORY · 2021-07-21T22:34:20Z

Summary

Test Plan

Additional Information

This change is backwards-breaking

github-actions · 2021-07-21T22:34:34Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2021-07-21T22:34:57Z

Oops! Looks like you failed the Semantic PR check.

Howto

Instructions on formatting your PR title
For PRs with only one commit, the commit message must also be semantic. See Changing a commit message for a howto
Guide to the different CI checks and resolution guidelines

♻️ Updated: ❌ The check is still failing the Semantic PR after the last commit.

github-actions · 2021-07-21T22:35:50Z

Oops! Looks like you failed the Semantic PR check.

Howto

github-actions · 2021-07-21T22:46:48Z

Oops! Looks like you failed the Semantic PR check.

Howto

github-actions · 2021-07-21T22:49:58Z

Oops! Looks like you failed the Semantic PR check.

Howto

github-actions · 2021-11-10T17:07:30Z

lte/gateway/python/magma/monitord/main.py


 def main():
-    """ main() for monitord service"""
+    """Start monitord"""


[misspell] _{reported by reviewdog 🐶}
"monitord" is a misspelling of "monitored"

github-actions · 2021-11-10T17:07:30Z

lte/gateway/c/core/oai/tasks/grpc_service/S8ServiceImpl.cpp

+        "Failed to allocate memory for S8_DELETE_BEARER_REQ for "
+        "context_teid" TEID_FMT "\n",
+        request->c_agw_teid());
+    return grpc::Status::CANCELLED;


[misspell] _{reported by reviewdog 🐶}
"CANCELLED" is a misspelling of "CANCELED"

github-actions · 2021-11-10T17:14:05Z

Oops! Looks like you failed the DCO check. Be sure to sign all your commits.

Howto

♻️ Updated: ❌ The check is still failing the DCO check after the last commit.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

misspell

github-actions · 2021-11-17T17:00:11Z

feg/gateway/sbi/defs/TS29122_GMDviaMBMSbyxMB.yaml

+          schema:
+            type: string
+      requestBody:
+        description: representation of the GMD via MBMS by xMB resource to be udpated in the SCEF


[misspell] _{reported by reviewdog 🐶}
"udpated" is a misspelling of "updated"

github-actions · 2021-11-17T17:00:11Z

feg/gateway/sbi/defs/TS29122_GMDviaMBMSbyxMB.yaml

+          schema:
+            type: string
+      requestBody:
+        description: representation of the GMD via MBMS by xMB resource to be udpated in the SCEF


[misspell] _{reported by reviewdog 🐶}
"udpated" is a misspelling of "updated"

github-actions · 2021-11-17T17:00:11Z

feg/gateway/sbi/defs/TS29122_ChargeableParty.yaml

+          schema:
+            type: string
+      requestBody:
+        description: representation of the chargeable party resource to be udpated in the SCEF


[misspell] _{reported by reviewdog 🐶}
"udpated" is a misspelling of "updated"

github-actions · 2021-11-17T17:00:12Z

feg/gateway/sbi/defs/TS29507_Npcf_AMPolicyControl.yaml

+            type: string
+      responses:
+        '204':
+          description: No Content. Resource was succesfully deleted


[misspell] _{reported by reviewdog 🐶}
"succesfully" is a misspelling of "successfully"

github-actions · 2021-11-17T17:00:12Z

feg/gateway/sbi/defs/TS29502_Nsmf_PDUSession.yaml

+          - PREPARING
+          - PREPARED
+          - COMPLETED
+          - CANCELLED


[misspell] _{reported by reviewdog 🐶}
"CANCELLED" is a misspelling of "CANCELED"

github-actions · 2021-11-17T17:00:17Z

feg/gateway/sbi/specs/TS29502NsmfPDUSession/TS29502NsmfPDUSession.gen.go

+	FailedToBeSwitched *bool                      `json:"failedToBeSwitched,omitempty"`
+	Guami              *externalRef2.Guami        `json:"guami,omitempty"`
+
+	// Possible values are - NONE - PREPARING - PREPARED - COMPLETED - CANCELLED


[misspell] _{reported by reviewdog 🐶}
"CANCELLED" is a misspelling of "CANCELED"

github-actions · 2021-11-17T17:00:17Z

feg/gateway/sbi/specs/TS29502NsmfPDUSession/TS29502NsmfPDUSession.gen.go

+	DataForwarding *bool                 `json:"dataForwarding,omitempty"`
+	EpsBearerSetup *[]EpsBearerContainer `json:"epsBearerSetup,omitempty"`
+
+	// Possible values are - NONE - PREPARING - PREPARED - COMPLETED - CANCELLED


[misspell] _{reported by reviewdog 🐶}
"CANCELLED" is a misspelling of "CANCELED"

github-actions · 2021-11-17T17:00:18Z

feg/gateway/sbi/specs/TS29512NpcfSMPolicyControlServer/TS29512NpcfSMPolicyControlServer.gen.go

+	VolUsageUplink *externalRef0.Volume `json:"volUsageUplink,omitempty"`
+}
+
+// Possible values are - NO_INFORMATION: Indicate that no information about the AF signalling protocol is being provided. - SIP: Indicate that the signalling protocol is Session Initiation Protocol.


[misspell] _{reported by reviewdog 🐶}
"signalling" is a misspelling of "signaling"

github-actions · 2021-11-17T17:00:18Z

feg/gateway/sbi/specs/TS29512NpcfSMPolicyControlServer/TS29512NpcfSMPolicyControlServer.gen.go

+	VolUsageUplink *externalRef0.Volume `json:"volUsageUplink,omitempty"`
+}
+
+// Possible values are - NO_INFORMATION: Indicate that no information about the AF signalling protocol is being provided. - SIP: Indicate that the signalling protocol is Session Initiation Protocol.


[misspell] _{reported by reviewdog 🐶}
"signalling" is a misspelling of "signaling"

github-actions · 2021-11-17T17:00:18Z

feg/gateway/sbi/specs/TS29512NpcfSMPolicyControlServer/TS29512NpcfSMPolicyControlServer.gen.go

+
+// PccRule defines model for PccRule.
+type PccRule struct {
+	// Possible values are - NO_INFORMATION: Indicate that no information about the AF signalling protocol is being provided. - SIP: Indicate that the signalling protocol is Session Initiation Protocol.


[misspell] _{reported by reviewdog 🐶}
"signalling" is a misspelling of "signaling"

github-actions · 2021-11-17T17:00:38Z

src/go/agwd/config/config.go

 		SctpdDownstreamServiceTarget:    "unix:///tmp/sctpd_downstream.sock",
 		SctpdUpstreamServiceTarget:      "unix:///tmp/sctpd_upstream.sock",
 		MmeSctpdDownstreamServiceTarget: "unix:///tmp/mme_sctpd_downstream.sock",
 		MmeSctpdUpstreamServiceTarget:   "unix:///tmp/mme_sctpd_upstream.sock",
 		// Sentry is disabled if DSN is not set.
-		SentryDsn: "",
+		SentryDsn:           "",


🚫 [golangci] _{reported by reviewdog 🐶}
File is not gofmt-ed with -s (gofmt)

github-actions · 2021-11-17T17:00:39Z

src/go/scripts/grpc-dialer/main.go

+	"google.golang.org/grpc"
+)
+
+


🚫 [golangci] _{reported by reviewdog 🐶}
File is not gofmt-ed with -s (gofmt)

Signed-off-by: quentinDERORY <15911421+quentinDERORY@users.noreply.github.com>

github-actions · 2021-11-17T17:03:19Z

feg/gateway/sbi/specs/TS29512NpcfSMPolicyControlServer/TS29512NpcfSMPolicyControlServer.gen.go

+	RefUmData *[]string `json:"refUmData"`
+}
+
+// Possible values are - PLMN_CH: PLMN Change - RES_MO_RE: A request for resource modification has been received by the SMF. The SMF always reports to the PCF. - AC_TY_CH: Access Type Change - UE_IP_CH: UE IP address change. The SMF always reports to the PCF. - UE_MAC_CH: A new UE MAC address is detected or a used UE MAC address is inactive for a specific period - AN_CH_COR: Access Network Charging Correlation Information - US_RE: The PDU Session or the Monitoring key specific resources consumed by a UE either reached the threshold or needs to be reported for other reasons. - APP_STA: The start of application traffic has been detected. - APP_STO: The stop of application traffic has been detected. - AN_INFO: Access Network Information report - CM_SES_FAIL: Credit management session failure - PS_DA_OFF: The SMF reports when the 3GPP PS Data Off status changes. The SMF always reports to the PCF. - DEF_QOS_CH: Default QoS Change. The SMF always reports to the PCF. - SE_AMBR_CH: Session AMBR Change. The SMF always reports to the PCF. - QOS_NOTIF: The SMF notify the PCF when receiving notification from RAN that QoS targets of the QoS Flow cannot be guranteed or gurateed again. - NO_CREDIT: Out of credit - PRA_CH: Change of UE presence in Presence Reporting Area - SAREA_CH: Location Change with respect to the Serving Area - SCNN_CH: Location Change with respect to the Serving CN node - RE_TIMEOUT: Indicates the SMF generated the request because there has been a PCC revalidation timeout - RES_RELEASE: Indicate that the SMF can inform the PCF of the outcome of the release of resources for those rules that require so. - SUCC_RES_ALLO: Indicates that the requested rule data is the successful resource allocation. - RAT_TY_CH: RAT Type Change. - REF_QOS_IND_CH: Reflective QoS indication Change - NUM_OF_PACKET_FILTER: Indicates that the SMF shall report the number of supported packet filter for signalled QoS rules - UE_STATUS_RESUME: Indicates that the UE’s status is resumed. - UE_TZ_CH: UE Time Zone Change


[misspell] _{reported by reviewdog 🐶}
"guranteed" is a misspelling of "guaranteed"

github-actions · 2021-11-17T17:03:20Z

feg/gateway/sbi/specs/TS29512NpcfSMPolicyControlServer/TS29512NpcfSMPolicyControlServer.gen.go

+	RefUmData *[]string `json:"refUmData"`
+}
+
+// Possible values are - PLMN_CH: PLMN Change - RES_MO_RE: A request for resource modification has been received by the SMF. The SMF always reports to the PCF. - AC_TY_CH: Access Type Change - UE_IP_CH: UE IP address change. The SMF always reports to the PCF. - UE_MAC_CH: A new UE MAC address is detected or a used UE MAC address is inactive for a specific period - AN_CH_COR: Access Network Charging Correlation Information - US_RE: The PDU Session or the Monitoring key specific resources consumed by a UE either reached the threshold or needs to be reported for other reasons. - APP_STA: The start of application traffic has been detected. - APP_STO: The stop of application traffic has been detected. - AN_INFO: Access Network Information report - CM_SES_FAIL: Credit management session failure - PS_DA_OFF: The SMF reports when the 3GPP PS Data Off status changes. The SMF always reports to the PCF. - DEF_QOS_CH: Default QoS Change. The SMF always reports to the PCF. - SE_AMBR_CH: Session AMBR Change. The SMF always reports to the PCF. - QOS_NOTIF: The SMF notify the PCF when receiving notification from RAN that QoS targets of the QoS Flow cannot be guranteed or gurateed again. - NO_CREDIT: Out of credit - PRA_CH: Change of UE presence in Presence Reporting Area - SAREA_CH: Location Change with respect to the Serving Area - SCNN_CH: Location Change with respect to the Serving CN node - RE_TIMEOUT: Indicates the SMF generated the request because there has been a PCC revalidation timeout - RES_RELEASE: Indicate that the SMF can inform the PCF of the outcome of the release of resources for those rules that require so. - SUCC_RES_ALLO: Indicates that the requested rule data is the successful resource allocation. - RAT_TY_CH: RAT Type Change. - REF_QOS_IND_CH: Reflective QoS indication Change - NUM_OF_PACKET_FILTER: Indicates that the SMF shall report the number of supported packet filter for signalled QoS rules - UE_STATUS_RESUME: Indicates that the UE’s status is resumed. - UE_TZ_CH: UE Time Zone Change


[misspell] _{reported by reviewdog 🐶}
"signalled" is a misspelling of "signaled"

github-actions · 2021-11-17T17:03:20Z

feg/gateway/sbi/specs/TS29512NpcfSMPolicyControlServer/TS29512NpcfSMPolicyControlServer.gen.go

+	SharingKeyUl *string `json:"sharingKeyUl,omitempty"`
+}
+
+// Possible values are - GENERAL: Indicate no specific QoS flow usage information is available. - IMS_SIG: Indicate that the QoS flow is used for IMS signalling only.


[misspell] _{reported by reviewdog 🐶}
"signalling" is a misspelling of "signaling"

github-actions · 2021-11-17T17:03:20Z

feg/gateway/sbi/specs/TS29512NpcfSMPolicyControlServer/TS29512NpcfSMPolicyControlServer.gen.go

+	Ipv6AddressPrefix *externalRef4.Ipv6Prefix `json:"ipv6AddressPrefix,omitempty"`
+	NotificationUri   externalRef4.Uri         `json:"notificationUri"`
+
+	// Contains the number of supported packet filter for signalled QoS rules.


[misspell] _{reported by reviewdog 🐶}
"signalled" is a misspelling of "signaled"

github-actions · 2021-11-17T17:03:20Z

feg/gateway/sbi/specs/TS29512NpcfSMPolicyControlServer/TS29512NpcfSMPolicyControlServer.gen.go

+	PduSessionType externalRef4.PduSessionType `json:"pduSessionType"`
+	Pei            *externalRef4.Pei           `json:"pei,omitempty"`
+
+	// Possible values are - GENERAL: Indicate no specific QoS flow usage information is available. - IMS_SIG: Indicate that the QoS flow is used for IMS signalling only.


[misspell] _{reported by reviewdog 🐶}
"signalling" is a misspelling of "signaling"

github-actions · 2021-11-17T17:03:22Z

feg/gateway/sbi/specs/TS29512NpcfSMPolicyControl/TS29512NpcfSMPolicyControl.gen.go

+	PduSessionType externalRef4.PduSessionType `json:"pduSessionType"`
+	Pei            *externalRef4.Pei           `json:"pei,omitempty"`
+
+	// Possible values are - GENERAL: Indicate no specific QoS flow usage information is available. - IMS_SIG: Indicate that the QoS flow is used for IMS signalling only.


[misspell] _{reported by reviewdog 🐶}
"signalling" is a misspelling of "signaling"

github-actions · 2021-11-17T17:03:22Z

feg/gateway/sbi/specs/TS29512NpcfSMPolicyControl/TS29512NpcfSMPolicyControl.gen.go

+	// Map of QoS data policy decisions.
+	QosDecs *SmPolicyDecision_QosDecs `json:"qosDecs,omitempty"`
+
+	// Possible values are - GENERAL: Indicate no specific QoS flow usage information is available. - IMS_SIG: Indicate that the QoS flow is used for IMS signalling only.


[misspell] _{reported by reviewdog 🐶}
"signalling" is a misspelling of "signaling"

github-actions · 2021-11-17T17:03:22Z

feg/gateway/sbi/specs/TS29512NpcfSMPolicyControl/TS29512NpcfSMPolicyControl.gen.go

+	Ipv4Address       *externalRef4.Ipv4Addr   `json:"ipv4Address,omitempty"`
+	Ipv6AddressPrefix *externalRef4.Ipv6Prefix `json:"ipv6AddressPrefix,omitempty"`
+
+	// Contains the number of supported packet filter for signalled QoS rules.


[misspell] _{reported by reviewdog 🐶}
"signalled" is a misspelling of "signaled"

github-actions · 2021-11-17T17:03:23Z

feg/gateway/sbi/specs/TS29512NpcfSMPolicyControl/TS29512NpcfSMPolicyControl.gen.go

+	// QoS Notification Control information.
+	QncReports *[]QosNotificationControlInfo `json:"qncReports,omitempty"`
+
+	// Possible values are - GENERAL: Indicate no specific QoS flow usage information is available. - IMS_SIG: Indicate that the QoS flow is used for IMS signalling only.


[misspell] _{reported by reviewdog 🐶}
"signalling" is a misspelling of "signaling"

github-actions · 2021-11-17T17:03:23Z

src/go/protos/magma/session_manager/session_manager.pb.go

+
+type UPFNodeState_AssociatonState struct {
+	// Message for establishing association
+	AssociatonState *UPFAssociationState `protobuf:"bytes,2,opt,name=associaton_state,json=associatonState,proto3,oneof"`


[misspell] _{reported by reviewdog 🐶}
"associaton" is a misspelling of "association"

github-actions · 2021-11-17T17:17:11Z

Oops! Looks like you failed the Python Format Check.

Howto

Instructions on running the formatter and linter locally are provided in the format AGW doc
Guide to the different CI checks and resolution guidelines

quentinDERORY force-pushed the quentin-testing branch from be89d8f to 7b54e68 Compare July 21, 2021 22:34

quentinDERORY force-pushed the quentin-testing branch from 7b54e68 to ac82dae Compare July 21, 2021 22:46

quentinDERORY force-pushed the quentin-testing branch from ac82dae to b1a474b Compare July 21, 2021 22:48

quentinDERORY force-pushed the quentin-testing branch from b1a474b to 2958f3c Compare October 1, 2021 21:20

quentinDERORY force-pushed the master branch from b1dc7a5 to f6eb1a3 Compare October 1, 2021 21:27

quentinDERORY force-pushed the master branch 20 times, most recently from 8d6a8a1 to c4583f5 Compare October 22, 2021 08:55

quentinDERORY force-pushed the master branch from 974abb6 to 7aca9e3 Compare November 1, 2021 12:30

quentinDERORY force-pushed the quentin-testing branch from 05ef37e to 3ac8cac Compare November 1, 2021 12:34

quentinDERORY force-pushed the master branch from 7aca9e3 to 7549109 Compare November 1, 2021 14:54

quentinDERORY force-pushed the quentin-testing branch from 3ac8cac to 31fb5c1 Compare November 1, 2021 14:57

quentinDERORY force-pushed the master branch from d97ab23 to a0fae33 Compare November 1, 2021 16:07

quentinDERORY force-pushed the quentin-testing branch 2 times, most recently from 287208b to cdd276c Compare November 2, 2021 09:03

quentinDERORY force-pushed the master branch from c0041ca to 4b38295 Compare November 2, 2021 15:03

quentinDERORY force-pushed the quentin-testing branch from cdd276c to a559b47 Compare November 4, 2021 16:55

github-actions bot added component: agw component: cwf component: feg labels Nov 4, 2021

quentinDERORY force-pushed the master branch from 7d3d50f to e1683af Compare November 4, 2021 17:05

github-actions bot removed component: agw component: cwf component: feg labels Nov 4, 2021

quentinDERORY force-pushed the quentin-testing branch 2 times, most recently from 1c18ecc to 3f72463 Compare November 10, 2021 17:06

github-actions bot reviewed Nov 10, 2021

View reviewed changes

quentinDERORY force-pushed the quentin-testing branch from 3f72463 to d973b4e Compare November 17, 2021 16:59

github-actions bot reviewed Nov 17, 2021

View reviewed changes

testing

90ad15d

Signed-off-by: quentinDERORY <15911421+quentinDERORY@users.noreply.github.com>

quentinDERORY force-pushed the quentin-testing branch from d973b4e to 90ad15d Compare November 17, 2021 17:02

github-actions bot reviewed Nov 17, 2021

View reviewed changes

quentinDERORY force-pushed the master branch 3 times, most recently from 4740a20 to 99eb849 Compare December 1, 2021 22:03

Conversation

quentinDERORY commented Jul 21, 2021

Summary

Test Plan

Additional Information

Uh oh!

github-actions bot commented Jul 21, 2021

Howto

More info

Uh oh!

github-actions bot commented Jul 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Howto

Uh oh!

github-actions bot commented Jul 21, 2021

Howto

Uh oh!

github-actions bot commented Jul 21, 2021

Howto

Uh oh!

github-actions bot commented Jul 21, 2021

Howto

Uh oh!

github-actions bot Nov 10, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 10, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Howto

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 17, 2021

Choose a reason for hiding this comment

github-actions bot commented Jul 21, 2021 •

edited

Loading

github-actions bot commented Nov 10, 2021 •

edited

Loading