[ci][dco] Automatically comment PR when failing DCO check#6
Open
quentinDERORY wants to merge 1 commit intomasterfrom
Open
[ci][dco] Automatically comment PR when failing DCO check#6quentinDERORY wants to merge 1 commit intomasterfrom
quentinDERORY wants to merge 1 commit intomasterfrom
Conversation
|
Thanks for opening a PR! 💯 Please note that all commits must be signed off. This is enforced by the Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
|
💥, Seems like you failed the Howto
|
Signed-off-by: Quentin, Derory <15911421+quentinDERORY@users.noreply.github.com>
b11e556 to
143bfe9
Compare
|
Oops, Seems like you failed the Howto
|
| script: | | ||
| var msg = `Oops, Seems like you failed the \`DCO check\`. Make sure to sign all your commits. | ||
|
|
||
| ### Howto |
There was a problem hiding this comment.
[yamllint] reported by reviewdog 🐶
[error] trailing spaces (trailing-spaces)
.github/workflows/dco-check.yml
Outdated
| script: | | ||
| var msg = `Oops, Seems like you failed the \`DCO check\`. Make sure to sign all your commits. | ||
|
|
||
| ### Howto |
There was a problem hiding this comment.
[yamllint] reported by reviewdog 🐶
[error] trailing spaces (trailing-spaces)
3957616 to
143bfe9
Compare
d099bdd to
2fabcc8
Compare
a2fb4be to
01eb4d4
Compare
de469d9 to
1db913e
Compare
5443c09 to
ec55ac5
Compare
c0041ca to
4b38295
Compare
quentinDERORY
pushed a commit
that referenced
this pull request
Nov 5, 2021
Fix:
1. Adding slice descriptor support in ics packet
2. Addressing magma#9939
Test:
1. test_oai
2. Simulator test call flow
Logs:
6/18 Test #6: test_ngap ......................... Passed 0.42
sec
ST/SD : 02 01 00 00 01
Signed-off-by: Yogesh Pandey <yogesh@wavelabs.ai>
6e1e847 to
4096e37
Compare
82f57b6 to
1c7c2ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Additional Information