-
Notifications
You must be signed in to change notification settings - Fork 23
Update documentation to remove variables no longer in use #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Removed the configuration for 'cairo.sql.jit.rows.threshold'.
Removed the configuration for the TCP writer queue size.
Removed the configuration for max memory pages for JIT compilation.
Removed the 'cairo.wal.commit.squash.row.limit' configuration option, which defined the maximum row count that could be squashed together from multiple transactions.
Removed configuration for CreateTableModel pool capacity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request removes obsolete configuration parameters from the QuestDB documentation that are no longer recognized by the system in version 9.0.3.
- Removes six deprecated configuration parameters that were causing "Invalid settings" warnings in QuestDB logs
- Cleans up documentation files to align with the current version's supported configuration options
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
documentation/configuration-utils/_wal.config.json | Removes cairo.wal.commit.squash.row.limit parameter |
documentation/configuration-utils/_tcp.config.json | Removes line.tcp.writer.queue.size parameter |
documentation/configuration-utils/_http.config.json | Removes http.response.header.buffer.size parameter |
documentation/configuration-utils/_cairo.config.json | Removes three parameters: cairo.sql.create.table.model.pool.capacity , cairo.sql.jit.rows.threshold , and cairo.sql.jit.ir.max.pages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising this! One small amendment, then its good to go
"default": "8K", | ||
"description": "Sets the memory page size for storing IR for JIT compilation." | ||
}, | ||
"cairo.sql.jit.ir.max.pages": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was replaced with:
cairo.sql.jit.ir.memory.max.pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deletion not required, just rename
I've updated documentation to remove variables that are no longer in use.
System: Ubuntu 24.04 (ARM)
Version: 9.0.3
Source: /var/lib/questdb/db/log/questdb-rolling.log.20250925