Skip to content

Conversation

mccaffers
Copy link

@mccaffers mccaffers commented Sep 25, 2025

I've updated documentation to remove variables that are no longer in use.

System: Ubuntu 24.04 (ARM)
Version: 9.0.3
Source: /var/lib/questdb/db/log/questdb-rolling.log.20250925

Invalid settings (not recognized, probable typos):
        * line.tcp.writer.queue.size
        * http.response.header.buffer.size
        * cairo.sql.jit.ir.max.pages
        * cairo.wal.commit.squash.row.limit
        * http.query.connection.limit
        * cairo.sql.create.table.model.pool.capacity

Removed the configuration for 'cairo.sql.jit.rows.threshold'.
Removed the configuration for the TCP writer queue size.
Removed the configuration for max memory pages for JIT compilation.
Removed the 'cairo.wal.commit.squash.row.limit' configuration option, which defined the maximum row count that could be squashed together from multiple transactions.
Removed configuration for CreateTableModel pool capacity.
@Copilot Copilot AI review requested due to automatic review settings September 25, 2025 08:41
@CLAassistant
Copy link

CLAassistant commented Sep 25, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes obsolete configuration parameters from the QuestDB documentation that are no longer recognized by the system in version 9.0.3.

  • Removes six deprecated configuration parameters that were causing "Invalid settings" warnings in QuestDB logs
  • Cleans up documentation files to align with the current version's supported configuration options

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
documentation/configuration-utils/_wal.config.json Removes cairo.wal.commit.squash.row.limit parameter
documentation/configuration-utils/_tcp.config.json Removes line.tcp.writer.queue.size parameter
documentation/configuration-utils/_http.config.json Removes http.response.header.buffer.size parameter
documentation/configuration-utils/_cairo.config.json Removes three parameters: cairo.sql.create.table.model.pool.capacity, cairo.sql.jit.rows.threshold, and cairo.sql.jit.ir.max.pages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@nwoolmer nwoolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this! One small amendment, then its good to go

"default": "8K",
"description": "Sets the memory page size for storing IR for JIT compilation."
},
"cairo.sql.jit.ir.max.pages": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was replaced with:

cairo.sql.jit.ir.memory.max.pages

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deletion not required, just rename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants