Skip to content

feat(nanos): update timestamp format to use UnixNano #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(nanos): update timestamp format to use UnixNano #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions buffer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,8 +553,8 @@ func (b *buffer) TimestampColumn(name string, ts time.Time) *buffer {
return b
}
b.WriteByte('=')
b.writeInt(ts.UnixMicro())
b.WriteByte('t')
b.writeInt(ts.UnixNano())
b.WriteByte('n')
b.hasFields = true
return b
}
Expand Down
2 changes: 1 addition & 1 deletion buffer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func TestTimestampSerialization(t *testing.T) {
assert.NoError(t, err)

// Check the buffer
expected := []byte("my_test_table a_col=" + strconv.FormatInt(tc.val.UnixMicro(), 10) + "t\n")
expected := []byte("my_test_table a_col=" + strconv.FormatInt(tc.val.UnixNano(), 10) + "n\n")
assert.Equal(t, expected, buf.Messages())
})
}
Expand Down
2 changes: 1 addition & 1 deletion integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ func setupQuestDB0(ctx context.Context, auth ilpAuthType, setupProxy bool) (*que
}
uniqueNetworkName := fmt.Sprintf("%s-%d", networkName, time.Now().UnixNano())
req := testcontainers.ContainerRequest{
Image: "questdb/questdb:9.0.2",
Image: "questdb/questdb:9.0.3",
ExposedPorts: []string{"9000/tcp", "9009/tcp"},
WaitingFor: wait.ForHTTP("/settings").WithPort("9000"),
Networks: []string{uniqueNetworkName},
Expand Down
Loading