feat: handle requested environment variables #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbritz
force-pushed
the
feat/request-env-vars
branch
4 times, most recently
from
b717033 to
0cd274c
Compare
janbritz
force-pushed
the
feat/request-env-vars
branch
from
0cd274c to
5e1681c
Compare
MartinGauk
reviewed
Nov 3, 2025
Contributor
Ja, aber ist schon angenehmer, wenn solche Standard-Sachen direkt definiert sind. Wenn wir die CPU-Nutzung per cgroups einschränken, sollten wir am besten den Wert auch dynamisch setzen. |
janbritz
force-pushed
the
feat/request-env-vars
branch
from
648a3ee to
01c677e
Compare
janbritz
force-pushed
the
feat/request-env-vars
branch
from
01c677e to
4efec60
Compare
MHajoha
reviewed
Nov 17, 2025
| ) | ||
|
|
||
| ENVIRONMENT_VARIABLE_REGEX: Final[str] = r"[a-zA-Z_][a-zA-Z0-9_]*" | ||
| ENVIRONMENT_VARIABLE = Annotated[str, Field(pattern=f"^{ENVIRONMENT_VARIABLE_REGEX}$")] |
Member
There was a problem hiding this comment.
Nicht eher EnvironmentVariable bzw. EnvironmentVariableName?
Comment on lines
+39
to
+67
| class Selector[T: Selectable, V](ABC): | ||
| """Provides helpful methods for getting package and request specific data.""" | ||
|
|
||
| def __init__(self, selectables: list[T]): | ||
| self._cache: LRUCacheMemory[SelectorQuery, V] = LRUCacheMemory(max_size=128) | ||
| self._selectables = selectables | ||
|
|
||
| def _get_matching(self, query: SelectorQuery) -> T | None: | ||
| """Gets the first matching selectable, if any. | ||
| It assumes that the selectables are ordered from least specific to most specific. | ||
| """ | ||
| for selectable in reversed(self._selectables): | ||
| if _is_matching(selectable.package_selector, query): | ||
| return selectable | ||
| return None | ||
|
|
||
| def get(self, query: SelectorQuery) -> V: | ||
| """Gets the result of the query, which may be cached.""" | ||
| if cached := self._cache.get(query): | ||
| return cached | ||
|
|
||
| result = self._get(query) | ||
| self._cache.put(query, result) | ||
|
|
||
| return result | ||
|
|
||
| @abstractmethod | ||
| def _get(self, query: SelectorQuery) -> V: ... |
Member
There was a problem hiding this comment.
Ich denke diese Klasse vermischt ein paar Dinge:
getcached_get_matchingmacht in 4 Zeilen das, was eigentlich im Klassennamen steht, und wählt den richtigen Eintrag aus den Selectables aus._getmachen in den Impls ziemlich verschiedene Dinge
Ich würde vorschlagen, das etwas zu refactoren:
_get_matchingwird eine Funktion (oderSelectoreine nicht-abstrakte Klasse, die nur das macht)PackagePermissionsHandlerundEnvironmentVariablesHandlerhaben keine Superklasse, sondern verwenden die neue Funktion- Die
_getwerden in den jeweiligen Klassen public. Falls Caching doch nötig sein sollte, sollte das da passieren.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #191
Mit
VAR: ${QPY_VAR}wird der Wert der UmgebungsvariableQPY_VARgelesen und verwendet. Wenn man explizit${QPY_VAR}als Wert übergeben will, müssen zwei Dollarzeichen verwendet werden:$${QPY_VAR}. Dieses Verhalten ähnelt dem von Docker und systemd.Wollen wir weiterhin
OPENBLAS_NUM_THREADSdemSubprocessWorkerübergeben? Theoretisch kann ein Admin das jetzt selber einstellen.