Conversation
vlaurin
force-pushed
the
single-axios-instance
branch
from
91b446a to
d0d7fca
Compare
Instead of creating an Axios instance for every request, allow for an Axios instance to be shared across all requests for a given client. This is required to enable the use of caching interceptors. As a consequence, interceptors can no longer be used for request-centric logic (abort/auth) and instead a decorator must be used.
vlaurin
force-pushed
the
single-axios-instance
branch
from
d0d7fca to
aca042c
Compare
gbenadikar
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of creating an Axios instance for every request, allow for an Axios instance to be shared across all requests for a given client. This is required to enable the use of caching interceptors.
As a consequence, interceptors can no longer be used for request-centric logic (abort/auth) and instead a decorator must be used.