Skip to content

Fix definition model #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vlaurin merged 2 commits into from
Feb 12, 2025
Merged

Fix definition model #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab7b469
Fix `DataField.Validation`
vlaurin Feb 12, 2025
2d10254
Fix `Field.Display`
vlaurin Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/main/java/app/quickcase/sdk/spring/definition/model/DataField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import java.util.List;
import java.util.Map;
import java.util.Optional;

import lombok.Builder;
import lombok.NonNull;
Expand All @@ -25,9 +24,9 @@ public record DataField(
) implements Field {
@Builder
public record Validation(
Integer min,
Optional<Integer> max,
Optional<String> pattern
String min,
String max,
String pattern
) {}

@Builder
Expand Down
11 changes: 7 additions & 4 deletions src/main/java/app/quickcase/sdk/spring/definition/model/Field.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,21 @@
package app.quickcase.sdk.spring.definition.model;

import java.util.Map;
import java.util.Optional;

import lombok.Builder;
import lombok.NonNull;
import lombok.Singular;

public interface Field {
@NonNull String id();
@NonNull String name();
String label();
Field.Display display();

interface Display {
String mode();
Map<String, String> parameters();
@Builder
record Display(
String mode,
@Singular Map<String, String> parameters
) {
}
}