Skip to content

Definition: Accept null for nullable singular#22

Closed
vlaurin wants to merge 1 commit intomainfrom
fix/null-singleton
Closed

Definition: Accept null for nullable singular#22
vlaurin wants to merge 1 commit intomainfrom
fix/null-singleton

Conversation

@vlaurin
Copy link
Copy Markdown
Contributor

@vlaurin vlaurin commented Feb 12, 2025

@Singular makes collection behave as non-nullable in builder by default; where a collection is actually nullable then @Singular must be made to explicitly follow that.

@vlaurin vlaurin requested a review from gbenadikar February 12, 2025 14:27
`@Singular` makes collection behave as non-nullable in builder by default; where a collection is actually nullable then `@Singular` must be made to explicitly follow that.
@vlaurin
Copy link
Copy Markdown
Contributor Author

vlaurin commented Feb 12, 2025

Actually, we don't want this. This causes null to be converted to an empty collection in the instantiated object when the intent is for the member to remain null.

@vlaurin vlaurin closed this Feb 12, 2025
@vlaurin vlaurin deleted the fix/null-singleton branch February 12, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants