Skip to content

Fix [sourceFieldPath] definition extraction #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vlaurin merged 1 commit into from
Feb 17, 2025
Merged

Fix [sourceFieldPath] definition extraction #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/main/java/app/quickcase/sdk/spring/definition/DefinitionExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,12 @@ public MetadataField extractField(MetadataFieldPath path) {
.name("Classification")
.label("Default record classification")
.build();
default -> throw new IllegalArgumentException("Path not supported in definition context: " + path);
// CaseLink metadata
case SOURCE_FIELD_PATH -> MetadataField.builder()
.id(path.toString())
.name("Link source field")
.label("Path of the field from which the link originated")
.build();
};
}

Expand Down
3 changes: 2 additions & 1 deletion ...test/java/app/quickcase/sdk/spring/condition/validate/SemanticConditionValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ void shouldReturnEmptySetWhenAllValid() {
var condition = new Condition(
new Criteria[][]{
new Criteria[]{
Criteria.builder().path("complex1").build()
Criteria.builder().path("complex1").build(),
Criteria.builder().path("[sourceFieldPath]").build()
},
new Criteria[]{
Criteria.builder().path("complex1.member1").build(),
Expand Down
22 changes: 11 additions & 11 deletions src/test/java/app/quickcase/sdk/spring/definition/DefinitionExtractorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,19 +143,19 @@ void shouldReturnLastModifiedAtField() {
));
}

@ParameterizedTest
@ValueSource(strings = {
"[sourceFieldPath]"
})
@DisplayName("should throw error for paths not supported in definition context")
void shouldThrowErrorForPathsNotSupported(String path) {
@Test
@DisplayName("should return sourceFieldPath field")
void shouldReturnSourceFieldPathField() {
var extractor = new DefinitionExtractor(recordType());
var error = assertThrows(
IllegalArgumentException.class,
() -> extractor.extractField(FieldPath.ofMetadata(path))
);
var field = extractor.extractField(FieldPath.ofMetadata("[sourceFieldPath]"));

assertThat(error.getMessage(), equalTo("Path not supported in definition context: " + path));
assertThat(field, equalTo(
MetadataField.builder()
.id("[sourceFieldPath]")
.name("Link source field")
.label("Path of the field from which the link originated")
.build()
));
}
}

Expand Down