Skip to content

allow sending unchanged message in Session#send #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2021
Merged

allow sending unchanged message in Session#send #395

merged 3 commits into from
Jul 30, 2021

Conversation

esanchezros
Copy link
Contributor

@esanchezros esanchezros commented May 17, 2021 •
edited by chrjohn
Loading

Fixes #394

@esanchezros
Copy link
Contributor Author

This PR is based on #236, which seems to be abandoned, and related to #394

@chrjohn chrjohn changed the title allowPosDup in Session#send allowPosDup in Session#send May 17, 2021
@chrjohn
Copy link
Member

chrjohn commented May 17, 2021

Hi @esanchezros , thanks for the PR.
The original PR also has a setting that permanently turns this feature on or off, although AFAICT it is not assigned in the Session constructor (maybe was forgotten). I think it would be beneficial to also have this setting. This then also needs to be put into `configuration.html'. If you have questions about this, just ask. :)

Cheers,
Chris.

chrjohn
chrjohn reviewed May 17, 2021
View reviewed changes
@esanchezros
Copy link
Contributor Author

Hi @chrjohn, I've updated the PR including your the configuration setting you mentioned. Let me know if it needs more work
Thanks
Ed

@esanchezros esanchezros mentioned this pull request May 21, 2021
Open
chrjohn
chrjohn reviewed May 26, 2021
View reviewed changes
chrjohn
chrjohn reviewed May 26, 2021
View reviewed changes
chrjohn
chrjohn reviewed May 26, 2021
View reviewed changes
@esanchezros
Copy link
Contributor Author

Gentle reminder for this PR to get merged if possible thanks

@chrjohn
Copy link
Member

chrjohn commented Jul 26, 2021 •
edited
Loading

Hi Ed, just back from vacation and slowly starting to pick things up where I left off... :) Sorry for the delay.

@esanchezros
Copy link
Contributor Author

No worries, thanks @chrjohn

@chrjohn
Copy link
Member

chrjohn commented Jul 27, 2021 •
edited
Loading

Closing and reopening to trigger complete Java CI checks. When this PR was created these weren't active yet.

@chrjohn chrjohn closed this Jul 27, 2021
@chrjohn chrjohn reopened this Jul 27, 2021
@chrjohn chrjohn changed the title allowPosDup in Session#send allow sending unchanged message in Session#send Jul 27, 2021
@chrjohn chrjohn merged commit 8eba4b3 into quickfix-j:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrjohn chrjohn chrjohn left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Be able to send a raw message without removing any field

2 participants

@esanchezros @chrjohn