Skip to content

[Junie]: feat: add AllocAcctIDSource values for consistency #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+65 −9
Open

[Junie]: feat: add AllocAcctIDSource values for consistency #997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f345fe
feat: add AllocAcctIDSource values for consistency
jetbrains-junie[bot] Jul 3, 2025
6c0b2b4
[issue-997] fix: update field values to resolve test failure
junie-eap[bot] Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion quickfixj-core/src/test/java/quickfix/RepeatingGroupTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ public void testIgnoreOutOfOrderGroupMembers() throws Exception {
final Message m = new Message(
"8=FIX.4.4\0019=0\00135=D\00134=2\00149=TW\00152=20080203-00:29:51.453\00156=ISLD\001" +
"11=ID\00121=1\00140=1\00154=1\00138=200.00\00155=INTC\00178=2\00179=acct1\00180=50\001" +
"661=10\00179=acct2\00180=150\001661=11\00160=20080203-00:29:51.453\00110=000\001",
"661=1\00179=acct2\00180=150\001661=2\00160=20080203-00:29:51.453\00110=000\001",
defaultDataDictionary, ignoreOutOfOrderSettings,false);
try {
defaultDataDictionary.validate(m, ignoreOutOfOrderSettings);
Expand Down
9 changes: 8 additions & 1 deletion quickfixj-core/src/test/resources/FIX44_Custom_Test.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5936,7 +5936,14 @@
<value enum="4" description="OMGEO" />
<value enum="5" description="DTCC_CODE" />
</field>
<field number="661" name="AllocAcctIDSource" type="INT" />
<field number="661" name="AllocAcctIDSource" type="INT">
<value enum="1" description="BIC"/>
<value enum="2" description="SID_CODE"/>
<value enum="3" description="TFM"/>
<value enum="4" description="OMGEO"/>
<value enum="5" description="DTCC_CODE"/>
<value enum="99" description="OTHER"/>
</field>
<field number="662" name="BenchmarkPrice" type="PRICE" />
<field number="663" name="BenchmarkPriceType" type="INT" />
<field number="664" name="ConfirmID" type="STRING" />
Expand Down
9 changes: 8 additions & 1 deletion quickfixj-messages/quickfixj-messages-fix44/src/main/resources/FIX44.modified.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6057,7 +6057,14 @@
<value enum="5" description="DTCC_CODE"/>
<value enum="99" description="OTHER"/>
</field>
<field number="661" name="AllocAcctIDSource" type="INT"/>
<field number="661" name="AllocAcctIDSource" type="INT">
<value enum="1" description="BIC"/>
<value enum="2" description="SID_CODE"/>
<value enum="3" description="TFM"/>
<value enum="4" description="OMGEO"/>
<value enum="5" description="DTCC_CODE"/>
<value enum="99" description="OTHER"/>
</field>
<field number="662" name="BenchmarkPrice" type="PRICE"/>
<field number="663" name="BenchmarkPriceType" type="INT"/>
<field number="664" name="ConfirmID" type="STRING"/>
Expand Down
9 changes: 8 additions & 1 deletion quickfixj-messages/quickfixj-messages-fix44/src/main/resources/FIX44.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6051,7 +6051,14 @@
<value enum="5" description="DTCC_CODE"/>
<value enum="99" description="OTHER"/>
</field>
<field number="661" name="AllocAcctIDSource" type="INT"/>
<field number="661" name="AllocAcctIDSource" type="INT">
<value enum="1" description="BIC"/>
<value enum="2" description="SID_CODE"/>
<value enum="3" description="TFM"/>
<value enum="4" description="OMGEO"/>
<value enum="5" description="DTCC_CODE"/>
<value enum="99" description="OTHER"/>
</field>
<field number="662" name="BenchmarkPrice" type="PRICE"/>
<field number="663" name="BenchmarkPriceType" type="INT"/>
<field number="664" name="ConfirmID" type="STRING"/>
Expand Down
9 changes: 8 additions & 1 deletion quickfixj-messages/quickfixj-messages-fix50/src/main/resources/FIX50.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6857,7 +6857,14 @@
<value enum="5" description="DTCC_CODE"/>
<value enum="99" description="OTHER"/>
</field>
<field number="661" name="AllocAcctIDSource" type="INT"/>
<field number="661" name="AllocAcctIDSource" type="INT">
<value enum="1" description="BIC"/>
<value enum="2" description="SID_CODE"/>
<value enum="3" description="TFM"/>
<value enum="4" description="OMGEO"/>
<value enum="5" description="DTCC_CODE"/>
<value enum="99" description="OTHER"/>
</field>
<field number="662" name="BenchmarkPrice" type="PRICE"/>
<field number="663" name="BenchmarkPriceType" type="INT"/>
<field number="664" name="ConfirmID" type="STRING"/>
Expand Down
9 changes: 8 additions & 1 deletion quickfixj-messages/quickfixj-messages-fix50sp1/src/main/resources/FIX50SP1.modified.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7599,7 +7599,14 @@
<value enum="5" description="DTCC_CODE"/>
<value enum="99" description="OTHER"/>
</field>
<field number="661" name="AllocAcctIDSource" type="INT"/>
<field number="661" name="AllocAcctIDSource" type="INT">
<value enum="1" description="BIC"/>
<value enum="2" description="SID_CODE"/>
<value enum="3" description="TFM"/>
<value enum="4" description="OMGEO"/>
<value enum="5" description="DTCC_CODE"/>
<value enum="99" description="OTHER"/>
</field>
<field number="662" name="BenchmarkPrice" type="PRICE"/>
<field number="663" name="BenchmarkPriceType" type="INT"/>
<field number="664" name="ConfirmID" type="STRING"/>
Expand Down
9 changes: 8 additions & 1 deletion quickfixj-messages/quickfixj-messages-fix50sp1/src/main/resources/FIX50SP1.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7593,7 +7593,14 @@
<value enum="5" description="DTCC_CODE"/>
<value enum="99" description="OTHER"/>
</field>
<field number="661" name="AllocAcctIDSource" type="INT"/>
<field number="661" name="AllocAcctIDSource" type="INT">
<value enum="1" description="BIC"/>
<value enum="2" description="SID_CODE"/>
<value enum="3" description="TFM"/>
<value enum="4" description="OMGEO"/>
<value enum="5" description="DTCC_CODE"/>
<value enum="99" description="OTHER"/>
</field>
<field number="662" name="BenchmarkPrice" type="PRICE"/>
<field number="663" name="BenchmarkPriceType" type="INT"/>
<field number="664" name="ConfirmID" type="STRING"/>
Expand Down
9 changes: 8 additions & 1 deletion quickfixj-messages/quickfixj-messages-fix50sp2/src/main/resources/FIX50SP2.modified.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7863,7 +7863,14 @@
<value enum="5" description="DTCC_CODE"/>
<value enum="99" description="OTHER"/>
</field>
<field number="661" name="AllocAcctIDSource" type="INT"/>
<field number="661" name="AllocAcctIDSource" type="INT">
<value enum="1" description="BIC"/>
<value enum="2" description="SID_CODE"/>
<value enum="3" description="TFM"/>
<value enum="4" description="OMGEO"/>
<value enum="5" description="DTCC_CODE"/>
<value enum="99" description="OTHER"/>
</field>
<field number="662" name="BenchmarkPrice" type="PRICE"/>
<field number="663" name="BenchmarkPriceType" type="INT"/>
<field number="664" name="ConfirmID" type="STRING"/>
Expand Down
9 changes: 8 additions & 1 deletion quickfixj-messages/quickfixj-messages-fix50sp2/src/main/resources/FIX50SP2.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7857,7 +7857,14 @@
<value enum="5" description="DTCC_CODE"/>
<value enum="99" description="OTHER"/>
</field>
<field number="661" name="AllocAcctIDSource" type="INT"/>
<field number="661" name="AllocAcctIDSource" type="INT">
<value enum="1" description="BIC"/>
<value enum="2" description="SID_CODE"/>
<value enum="3" description="TFM"/>
<value enum="4" description="OMGEO"/>
<value enum="5" description="DTCC_CODE"/>
<value enum="99" description="OTHER"/>
</field>
<field number="662" name="BenchmarkPrice" type="PRICE"/>
<field number="663" name="BenchmarkPriceType" type="INT"/>
<field number="664" name="ConfirmID" type="STRING"/>
Expand Down