Add changeHandler opt#10
Merged
quicksketch merged 2 commits intoquicksketch:masterfrom Dec 14, 2013
Merged
Conversation
Owner
|
Thanks! Could this problem also be solved by #5? That would allow you to bind directly to the browser-level change events. Otherwise, this looks like a good option to have, but it should also be documented. |
Contributor
Author
|
Yes, but I think this one is more flexible than #5. I already added the following lines to README.md should I document it anywhere else? |
Owner
|
Sure, I think that would be adequate. I've got a few other minor nitpicks that I'll add to the diff. |
Finish changeHandler comments with a period. Remove the whitespace in line 73.
Contributor
Author
|
Done. |
quicksketch
added a commit
that referenced
this pull request
Dec 14, 2013
Added new option for specifying a handler on timezone change.
Owner
|
Super. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just added the
changeHandleroption.It should be a function with the following signature:
which gets called upon timezone change.
That makes
timezonepickermuch easier to use on Android/JavaFX WebView or similar environments via a bridge.Also I used uglifyjs with default options for minification. Let me know if there's a better minifier/configuration that I should use.